From: Hans Verkuil <hverkuil@xs4all.nl>
To: Christian Hewitt <christianshewitt@gmail.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Maxime Jourdan <mjourdan@baylibre.com>,
Benjamin Roszak <benjamin545@gmail.com>
Subject: Re: [PATCH v3 2/2] media: meson: vdec: add HEVC decode codec
Date: Tue, 21 Mar 2023 15:25:10 +0100 [thread overview]
Message-ID: <558a8afc-f62d-aec7-aca5-5d26471ba332@xs4all.nl> (raw)
In-Reply-To: <20230314114318.4057353-3-christianshewitt@gmail.com>
On 14/03/2023 12:43, Christian Hewitt wrote:
> From: Maxime Jourdan <mjourdan@baylibre.com>
>
> Add initial HEVC codec for the Amlogic GXBB/GXL/GXM SoCs using
> the common "HEVC" decoder driver.
>
> Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
> [codec alignment to upstream changes and frame handling improvements]
> Signed-off-by: Benjamin Roszak <benjamin545@gmail.com>
> ---
> drivers/staging/media/meson/vdec/Makefile | 2 +-
> drivers/staging/media/meson/vdec/codec_hevc.c | 1463 +++++++++++++++++
> drivers/staging/media/meson/vdec/codec_hevc.h | 13 +
> drivers/staging/media/meson/vdec/esparser.c | 3 +-
> drivers/staging/media/meson/vdec/hevc_regs.h | 1 +
> .../staging/media/meson/vdec/vdec_platform.c | 37 +
> 6 files changed, 1517 insertions(+), 2 deletions(-)
> create mode 100644 drivers/staging/media/meson/vdec/codec_hevc.c
> create mode 100644 drivers/staging/media/meson/vdec/codec_hevc.h
>
<snip>
> diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
> index 88c9d72e1c83..ea2aa0e8cf0b 100644
> --- a/drivers/staging/media/meson/vdec/vdec_platform.c
> +++ b/drivers/staging/media/meson/vdec/vdec_platform.c
> @@ -11,10 +11,23 @@
> #include "vdec_hevc.h"
> #include "codec_mpeg12.h"
> #include "codec_h264.h"
> +#include "codec_hevc.h"
> #include "codec_vp9.h"
>
> static const struct amvdec_format vdec_formats_gxbb[] = {
> {
> + .pixfmt = V4L2_PIX_FMT_HEVC,
> + .min_buffers = 4,
> + .max_buffers = 24,
> + .max_width = 3840,
> + .max_height = 2160,
> + .vdec_ops = &vdec_hevc_ops,
> + .codec_ops = &codec_hevc_ops,
> + .firmware_path = "meson/vdec/gxl_hevc.bin",
> + .pixfmts_cap = { V4L2_PIX_FMT_NV12M, 0 },
> + .flags = V4L2_FMT_FLAG_COMPRESSED |
> + V4L2_FMT_FLAG_DYN_RESOLUTION,
> + }, {
> .pixfmt = V4L2_PIX_FMT_H264,
> .min_buffers = 2,
> .max_buffers = 24,
> @@ -64,6 +77,18 @@ static const struct amvdec_format vdec_formats_gxl[] = {
> .pixfmts_cap = { V4L2_PIX_FMT_NV12M, 0 },
> .flags = V4L2_FMT_FLAG_COMPRESSED |
> V4L2_FMT_FLAG_DYN_RESOLUTION,
> + }, {
> + .pixfmt = V4L2_PIX_FMT_HEVC,
> + .min_buffers = 4,
> + .max_buffers = 24,
> + .max_width = 3840,
> + .max_height = 2160,
> + .vdec_ops = &vdec_hevc_ops,
> + .codec_ops = &codec_hevc_ops,
> + .firmware_path = "meson/vdec/gxl_hevc.bin",
> + .pixfmts_cap = { V4L2_PIX_FMT_NV12M, 0 },
> + .flags = V4L2_FMT_FLAG_COMPRESSED |
> + V4L2_FMT_FLAG_DYN_RESOLUTION,
> }, {
> .pixfmt = V4L2_PIX_FMT_H264,
> .min_buffers = 2,
> @@ -114,6 +139,18 @@ static const struct amvdec_format vdec_formats_gxm[] = {
> .pixfmts_cap = { V4L2_PIX_FMT_NV12M, 0 },
> .flags = V4L2_FMT_FLAG_COMPRESSED |
> V4L2_FMT_FLAG_DYN_RESOLUTION,
> + }, {
> + .pixfmt = V4L2_PIX_FMT_HEVC,
> + .min_buffers = 4,
> + .max_buffers = 24,
> + .max_width = 3840,
> + .max_height = 2160,
> + .vdec_ops = &vdec_hevc_ops,
> + .codec_ops = &codec_hevc_ops,
> + .firmware_path = "meson/vdec/gxl_hevc.bin",
Hmm, I don't see this firmware in any debian package. Is it made available to
linux-firmware? This actually applies to *all* meson/vdec/ firmwares.
Regards,
Hans
> + .pixfmts_cap = { V4L2_PIX_FMT_NV12M, 0 },
> + .flags = V4L2_FMT_FLAG_COMPRESSED |
> + V4L2_FMT_FLAG_DYN_RESOLUTION,
> }, {
> .pixfmt = V4L2_PIX_FMT_H264,
> .min_buffers = 2,
next prev parent reply other threads:[~2023-03-21 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 11:43 [PATCH v3 0/2] media: meson: vdec: add HEVC decode codec Christian Hewitt
2023-03-14 11:43 ` [PATCH v3 1/2] media: meson: vdec: implement 10bit bitstream handling Christian Hewitt
2023-03-21 14:21 ` Hans Verkuil
2023-03-14 11:43 ` [PATCH v3 2/2] media: meson: vdec: add HEVC decode codec Christian Hewitt
2023-03-21 14:25 ` Hans Verkuil [this message]
2023-03-21 15:30 ` Christian Hewitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558a8afc-f62d-aec7-aca5-5d26471ba332@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=benjamin545@gmail.com \
--cc=christianshewitt@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin.blumenstingl@googlemail.com \
--cc=mchehab@kernel.org \
--cc=mjourdan@baylibre.com \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).