From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752616AbbF1OxB (ORCPT ); Sun, 28 Jun 2015 10:53:01 -0400 Received: from mout.web.de ([212.227.17.11]:59642 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752222AbbF1Owx (ORCPT ); Sun, 28 Jun 2015 10:52:53 -0400 Message-ID: <55900A20.5070407@users.sourceforge.net> Date: Sun, 28 Jun 2015 16:52:16 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Bjorn Helgaas , Ray Jui , Scott Branden , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com CC: LKML , kernel-janitors@vger.kernel.org, Hauke Mehrtens , Julia Lawall Subject: [PATCH] PCI-iproc: Delete unnecessary checks before two function calls References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:uhXOqQjDxWWyvWC14+TiFYEPjk4Nf0MdcGEEs3autNI5OZ7rJ3k GJJkjXQjEotHcLBxFOZGspnNqiwgH63dXBl3HdVPEXG6EMx2v6RiqMOK0VpeTbtL8AsOXhT kg3wLKEYH33LMRwmm2cvmrurfLXDwhy6p0fHFPxmY9YMkhEoJzTgxHizX1hKSkeWLeOc6UN jm367NECGZxDzNACbmckA== X-UI-Out-Filterresults: notjunk:1;V01:K0:M0dO/atJ3jk=:xqzBJRWKSN6RryXTDCiEKD H3+CKFz/h5zGeCcYt/IdkMXN/SirsCpZZNKkUzuIuGud9pa4fHM0PO2R6qW1CO4WOy3Nba9Ae im7352tnAURZJ8Ek44+jBpnGVds+gEv0AsOe6EZzFRu2AM7XokpceBravwXjelJGBw3XUToiy IrHGFyvtVmGcNR7Smpl3UBYpPIXTu/VH6k9VJfuGRET9qWm5vUE/vXey4pfRd2hARo8Up3lBr GUTieVeAH1S0nQJ4nRKjN2TRkzRuL91fu3WD4air5QNlKq3H3zO1NpK6u2QBw40RscCbOxNIF 324jYgQxcSFa8NF6xgzCmHqS94vkIZKfYOZFuSUUmilA1IIQZ663SmzEt62GFDKW5ugghHqX0 ISxXYbxHzI6/T9PtTosSUOOb+R099jc/yjazzCuZ1pUOsxEzzG6gcYHhomTNvqhWFpD84+B4U RkrnACoFh1MIIXZ+C5BD8LHp46RT2/15AsMRzW9l6zEOfZ299bRus/KCucmcKkPG6jxqnTI4h 5YYmeEiOdev3X8JrIEsa+WH0SRDpDncw+bn/FsWG4GekN4hqMXJNVe5NpgG/KbxNYZdPGJS5u XyrPNXrYRMwzGLtH20g0adVFuNLtysnEQahzTYWemLYrMbB+q3mBbPHE1Ft55azI0sHtZvj3l ZimBDOyEEp4P59hnSxXVRSBlZJWpm8twJd7ELOWp65x1sKBW4nW3hLsMp9AkJNwbhCek= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 28 Jun 2015 16:42:04 +0200 The functions phy_exit() and phy_power_off() test whether their argument is NULL and then return immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pci/host/pcie-iproc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/pci/host/pcie-iproc.c b/drivers/pci/host/pcie-iproc.c index d77481e..f875821 100644 --- a/drivers/pci/host/pcie-iproc.c +++ b/drivers/pci/host/pcie-iproc.c @@ -239,12 +239,9 @@ err_rm_root_bus: pci_remove_root_bus(bus); err_power_off_phy: - if (pcie->phy) - phy_power_off(pcie->phy); + phy_power_off(pcie->phy); err_exit_phy: - if (pcie->phy) - phy_exit(pcie->phy); - + phy_exit(pcie->phy); return ret; } EXPORT_SYMBOL(iproc_pcie_setup); -- 2.4.4