From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751464AbbF2JzP (ORCPT ); Mon, 29 Jun 2015 05:55:15 -0400 Received: from smtp65.iad3a.emailsrvr.com ([173.203.187.65]:54821 "EHLO smtp65.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752899AbbF2JzG (ORCPT ); Mon, 29 Jun 2015 05:55:06 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <559115F7.4050100@mev.co.uk> Date: Mon, 29 Jun 2015 10:55:03 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: SF Markus Elfring , Greg Kroah-Hartman , H Hartley Sweeten , devel@driverdev.osuosl.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] staging: comedi: adl_pci9118: Delete an unnecessary check before the function call "pci_dev_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <558E92BA.2090101@users.sourceforge.net> In-Reply-To: <558E92BA.2090101@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/06/15 13:10, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 27 Jun 2015 13:50:43 +0200 > > The pci_dev_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/staging/comedi/drivers/adl_pci9118.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c > index fb3043d..19b5806 100644 > --- a/drivers/staging/comedi/drivers/adl_pci9118.c > +++ b/drivers/staging/comedi/drivers/adl_pci9118.c > @@ -1717,8 +1717,7 @@ static void pci9118_detach(struct comedi_device *dev) > pci9118_reset(dev); > comedi_pci_detach(dev); > pci9118_free_dma(dev); > - if (pcidev) > - pci_dev_put(pcidev); > + pci_dev_put(pcidev); > } > > static struct comedi_driver adl_pci9118_driver = { > The same patch was posted independently (and earlier) by Maninder Singh, but I think we concluded that the code was more understandable without this change, as the test within pci_dev_put() is more of a safety net. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-