From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752824AbbF2NlJ (ORCPT ); Mon, 29 Jun 2015 09:41:09 -0400 Received: from mout.web.de ([212.227.17.12]:57181 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753153AbbF2NlB (ORCPT ); Mon, 29 Jun 2015 09:41:01 -0400 Message-ID: <55914AE5.6030906@users.sourceforge.net> Date: Mon, 29 Jun 2015 15:40:53 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Vyacheslav Dubeyko , linux-fsdevel@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] hfs/hfs+: Deletion of unnecessary checks before the function call "hfs_bnode_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546A3C2A.9050401@users.sourceforge.net> <1416251896.2937.1.camel@ubuntu> In-Reply-To: <1416251896.2937.1.camel@ubuntu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:dbr+nAkTw89fb/iM+KGbTXb/+VLmNlshL1rQ63V3N/VtBJL6miQ dJ9LkBeXUZ2phietl9xgciCwMZWE0+M6plMPPXnwvcSP0uc8LOo4R7WtJR5B4xZJBOP30+6 l0/LPCdZ9bjqorV54vdzrfbLBsrZi9ryGXIIa4EqLFsrugy2xLHuIUNvsC6C92cVyRm0PJ+ ipFgNThHdxr4uCK4PwyPA== X-UI-Out-Filterresults: notjunk:1;V01:K0:AbblV3O117M=:jGC/kLG0rkLqfMJCP+d/rj uMgRYkED/8vFhA78Q+cfPbOuyc2T3TnLczM6GoOG/m8HyPzQiNRZRNi2G/zw0L2l+pgRJuAt3 B72Eqtr8nvT0zJrGJ66Txsa4RRPA+VCxBsiJleAVunJIqj6reN/AwuuchZ9OkFPj3vTbx0n4Y wwM8ZRKrOssem31F1BcTUmQ4CV9QzNJN6Vf8Mwty9zN1zkqSDdiPWS+2farlMHJzCZIEmo4w8 88zlU1Fc3Yi2dC3RfFxEGD35vO3HSg53EsN85FiSOLs7J0Dq9XUnxXTtEtapkHobWrAJ61CNN dWPufKp2PN6fU1KGSf/l2nJrXSgToBh/Uz80G1vXiaJxxY+64yLbGheOwjg01XWeen7dyWkdR 6nZvX17/M2SAEM/edr5hC8gXiLYfqdMLnngRy3jvWfFZSJ8Gkw40LgvRCcuySwEgJ/tNU3eHt cRxlf/emndUDhyMq0ULomrOCH2CxmDRMXQiVslxantBAWMoggv65cYSvyYJoyGJzgB3DOxkOA HGc04oTrwB/pqmWuRoFsbgMjZ0ZQAGWFTQ0K7ZVdY5oYxqpipFTvv1sAFxPzwyvozsIKaxX0j mjHkVBVXAR/E+DxVHZQh6U6VApVYm6KLcQsHTCPsnQs4n/Zq5Tucr57Pg4jJoSCxHjqNx88Ax A2yYcSv4GNtScwBX5vzsK64l+UdOQ+oEsB76EoeltkSBzVNAdQ0+MTtkt5Sq19KZ6Ajo= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> From: Markus Elfring >> Date: Mon, 17 Nov 2014 19:13:56 +0100 >> >> The hfs_bnode_put() function tests whether its argument is NULL and then >> returns immediately. Thus the test around the call is not needed. >> >> This issue was detected by using the Coccinelle software. >> > > Thank you. It's the reasonable correction. Looks good for me. > > Reviewed-by: Vyacheslav Dubeyko > > Thanks, > Vyacheslav Dubeyko. > >> Signed-off-by: Markus Elfring >> --- >> fs/hfs/bfind.c | 3 +-- >> fs/hfs/brec.c | 3 +-- >> fs/hfsplus/bfind.c | 3 +-- >> fs/hfsplus/brec.c | 3 +-- >> 4 files changed, 4 insertions(+), 8 deletions(-) >> >> diff --git a/fs/hfs/bfind.c b/fs/hfs/bfind.c >> index de69d8a..0e26523 100644 >> --- a/fs/hfs/bfind.c >> +++ b/fs/hfs/bfind.c >> @@ -100,8 +100,7 @@ int hfs_brec_find(struct hfs_find_data *fd) >> int height, res; >> >> tree = fd->tree; >> - if (fd->bnode) >> - hfs_bnode_put(fd->bnode); >> + hfs_bnode_put(fd->bnode); >> fd->bnode = NULL; >> nidx = tree->root; >> if (!nidx) >> diff --git a/fs/hfs/brec.c b/fs/hfs/brec.c >> index 9f4ee7f..3a52b2c 100644 >> --- a/fs/hfs/brec.c >> +++ b/fs/hfs/brec.c >> @@ -272,8 +272,7 @@ static struct hfs_bnode *hfs_bnode_split(struct hfs_find_data *fd) >> /* panic? */ >> hfs_bnode_put(node); >> hfs_bnode_put(new_node); >> - if (next_node) >> - hfs_bnode_put(next_node); >> + hfs_bnode_put(next_node); >> return ERR_PTR(-ENOSPC); >> } >> >> diff --git a/fs/hfsplus/bfind.c b/fs/hfsplus/bfind.c >> index c1422d9..7be88e3 100644 >> --- a/fs/hfsplus/bfind.c >> +++ b/fs/hfsplus/bfind.c >> @@ -171,8 +171,7 @@ int hfs_brec_find(struct hfs_find_data *fd, search_strategy_t do_key_compare) >> int height, res; >> >> tree = fd->tree; >> - if (fd->bnode) >> - hfs_bnode_put(fd->bnode); >> + hfs_bnode_put(fd->bnode); >> fd->bnode = NULL; >> nidx = tree->root; >> if (!nidx) >> diff --git a/fs/hfsplus/brec.c b/fs/hfsplus/brec.c >> index 6e560d5..59bab47 100644 >> --- a/fs/hfsplus/brec.c >> +++ b/fs/hfsplus/brec.c >> @@ -276,8 +276,7 @@ static struct hfs_bnode *hfs_bnode_split(struct hfs_find_data *fd) >> /* panic? */ >> hfs_bnode_put(node); >> hfs_bnode_put(new_node); >> - if (next_node) >> - hfs_bnode_put(next_node); >> + hfs_bnode_put(next_node); >> return ERR_PTR(-ENOSPC); >> } >> > > Can this update suggestion be still integrated into another source code repository? Regards, Markus