From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750997AbbF3GIn (ORCPT <rfc822;w@1wt.eu>);
	Tue, 30 Jun 2015 02:08:43 -0400
Received: from mout.web.de ([212.227.15.3]:51868 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751112AbbF3GIg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 30 Jun 2015 02:08:36 -0400
Message-ID: <55923251.7070306@users.sourceforge.net>
Date: Tue, 30 Jun 2015 08:08:17 +0200
From: SF Markus Elfring <elfring@users.sourceforge.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Alexey Kardashevskiy <aik@ozlabs.ru>,
        Alex Williamson <alex.williamson@redhat.com>, kvm@vger.kernel.org
CC: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>,
        Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: vfio: powerpc/spapr: One function call less in tce_iommu_attach_group()
 after kzalloc() failure
References: <5307CAA2.8060406@users.sourceforge.net> <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6> <530A086E.8010901@users.sourceforge.net> <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6> <530A72AA.3000601@users.sourceforge.net> <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6> <530B5FB6.6010207@users.sourceforge.net> <alpine.DEB.2.10.1402241710370.2074@hadrien> <530C5E18.1020800@users.sourceforge.net> <alpine.DEB.2.10.1402251014170.2080@hadrien> <530CD2C4.4050903@users.sourceforge.net> <alpine.DEB.2.10.1402251840450.7035@hadrien> <530CF8FF.8080600@users.sourceforge.net> <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6> <530DD06F.4090703@users.sourceforge.net> <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6> <5317A59D.4@users.sourceforge.net> <55901E68.80205@users.sourceforge.net> <55901FAC.1090109@users.sourceforge.net> <5590862A.3010603@ozlabs.ru> <5590DF8A.8030503@users.sourceforge.net> <5591E355.1080708@ozlabs.ru>
In-Reply-To: <5591E355.1080708@ozlabs.ru>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:4KdVaEHQwrT25PEJvPu5zVDsbCdnz2OxBhkxvP7Icznck/DnyDt
 Al/7q3E4wdTbwjphMoWQlo4DmdiAUnFGQVf+PB78rBNzFo/fEzHki2qh9xdb5C+0oUjgfY5
 VLljIqkZYBYKsvgKR/RYCv/c/tQnMOpnRGwT77XncVu1FyYCZOhAAJXZmt1vfd1XQXZfJkM
 I0LgaO8rJwxuIUDbAMWyg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:m9YZ9FXoQHc=:LDe/WHd3r1e4qNEHRwQYnn
 Synqi61J0dL78sfLJPmNch2Y96iwRVweqhw1PlqfsfTMjJtfBYCS/u/r2vri3BRlStMYFcUYr
 Q8e532Ur+sck0dLN5BMXxA6W+iwb43o2T/xfeaGJplfpRAs76wnpX7LFTO1eaf5B7S2ZpnqYf
 fJdtQotLspi8EcbHQ+0/n3eLUQLPYVzYCzP8QMeELWb9yhFoZReGUq89yVdmfO1hzzaRTgioX
 f91wOMrXum3Lh9Z52nHd9EcSA1oWEbxgDYH8EmNI61nsnYm72FJT7H0zM+5V8DBxEj+lmUhhG
 CnC4qI9UE5EKy4b8nOJzx6nwO8H9j4OAkqNbykZ74fssiz9z152wlkFN4zvMmDn3TTevEvjss
 pYRswNz0XKP8lXSjr313Ms5tgaTafTCYlFGdP6ZGsoFcFUMb6kEO1JwaT8GkQdOXUMDvIHwXn
 OPmd1D3GIAn18rhXmmPP5YG2zgTQK3NhZ+8XiwlkQlqsY/W4n8kYlC9QtehTPeccBIrap+JkU
 zeJkJi4QjT0jMVbyWrd4JjWSabO2giDp3PJUdLBww820P3tQwzuxf2wF+smgQmWjAvDnWCA+2
 VfxpLczZp3OrGX+aEF6O5KYghkQbpV4EDoShQyKrEqWi25P53RmzcgPXBKeeWswFvQK45SFwx
 L8Fxpo19fwa0lZtK7sETwCJmoP7FQ+wp+oFl5W+oexGl3CxrZ11M5wu7dtw0Vp0hW6E4=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>> than the existing one should have been renamed to "free_exit" or "free_unlock_exit"
>>> and new one would be "unlock_exit".
>>
>> I chose a smaller change at this place.
> 
> I'd just drop this patch.

How do you think about to improve the affected jump labels
a bit more there?

Regards,
Markus