From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752574AbbF3IOP (ORCPT ); Tue, 30 Jun 2015 04:14:15 -0400 Received: from mout.web.de ([212.227.17.12]:63895 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124AbbF3IOG (ORCPT ); Tue, 30 Jun 2015 04:14:06 -0400 Message-ID: <55924FC2.3070006@users.sourceforge.net> Date: Tue, 30 Jun 2015 10:13:54 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] macintosh: Delete an unnecessary check before the function call "of_node_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54D282B0.90907@users.sourceforge.net> In-Reply-To: <54D282B0.90907@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:dy84081XXg/0Ol0fhCWZIWF6CNjPCw/3lJRBjktF0cux7KZm3if CIAubIN/mpVw62jd1qjhS4oiOKhNEPtC0BEo09lSBN0491yw2zhTkgddvFzNoTOknxVg3c3 YdXDYdLSW43GMFc78YEKvl41K5o/+Ux+EBqmcikpsy62qGSqGWBgRqoWMkwKitRYyf6GKLw JjpCYOa5a85j5W+zbMkIg== X-UI-Out-Filterresults: notjunk:1;V01:K0:MXA/kvALEao=:ZaCyy76yB7GZw5+t6eGVZh iPGckODTACroNC5RfsAzmmzEs3RipbhW22xuI5X0LwxO1xttfRCGB0IJcXYBe12XtP5nPcM4C 8dRT6PL7kK3aLmAg6L2XwBVsI+Sn6MIsLiJnXFC/hNGW/Hl/6KCbcOmt4o5f5WCZ4IaFVY+j9 0rEHB/PgVFj/W3dQIOkm1ytjW4xVXp1tAKp2godKf8rmhtvW4Jr8qxdSYZPcXWyEj5wCPntVn ZyPZLkZpUD1SMSy7gi0PcHM9pnzre7DLDzwpGxBt3T+c1eBN8sueEE9pEypYqmoGe5vegP4GJ 6IDR5Uze+9yMyZTUC1Vy2aBli7ZTqxtKhZ1NSGYAEb0DGh02I9VLiSWJEDWuxQJ7oT4aH0UVA t2+5ott2Q0pcRkIVOdtw9f+bd0GZAiep4WfT/TD5ELOLYEWOYrsiJEX1qomYdAbrCObxSCrPt 6JhWeE0tBPXvL2yYYAk6Pl9hgvHGM0GA1qW85HCwMMCvLec1LQXG/2wjEADntxp5VbsHHAGeg fDadEVoaeTa7iTTITWNbLLhbxPIbyfjYXmCdgugMMTYV48m75zcdWGHurGnOkAozffxlcr9Pm rO+/1G0x6xam01dGCJJz6JfEHSKkf3xxLnmdZkkMIYI3dJc+EaO1omYBPAdtePyLqDZ8FYcX9 YzlW3Uw8YN5jmqem9v52/jUH4KffKi7pUPWkbmDGiY9L1FwzZvLwIisfUAAZK0Ui4860= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 04.02.2015 um 21:36 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Wed, 4 Feb 2015 21:32:27 +0100 > > The of_node_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/macintosh/smu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c > index 10ae69b..d531f80 100644 > --- a/drivers/macintosh/smu.c > +++ b/drivers/macintosh/smu.c > @@ -557,8 +557,7 @@ int __init smu_init (void) > return 0; > > fail_msg_node: > - if (smu->msg_node) > - of_node_put(smu->msg_node); > + of_node_put(smu->msg_node); > fail_db_node: > of_node_put(smu->db_node); > fail_bootmem: > Would you like to integrate this update suggestion into another source code repository? Regards, Markus