From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753370AbbF3MjL (ORCPT ); Tue, 30 Jun 2015 08:39:11 -0400 Received: from mout.web.de ([212.227.15.14]:49173 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753623AbbF3Miy (ORCPT ); Tue, 30 Jun 2015 08:38:54 -0400 Message-ID: <55928DCF.9000708@users.sourceforge.net> Date: Tue, 30 Jun 2015 14:38:39 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Anil Gurumurthy , "James E. J. Bottomley" , Sudarsana Kalluru , linux-scsi CC: linux-kernel , "kernel-janitors@vger.kernel.org" , Julia Lawall Subject: Re: [PATCH] SCSI-bfa: Deletion of an unnecessary check before the function call "vfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546E6F5C.6050604@users.sourceforge.net> <20B1A3CBD98F3845B3F5F56D8597EF59FD4B5D@avmb2.qlogic.org> In-Reply-To: <20B1A3CBD98F3845B3F5F56D8597EF59FD4B5D@avmb2.qlogic.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:/rhy9oYyfNlO9Xzc0nfSMY038owyNLFOeoMnMBKvsrdy4rRX5Gc j+8XiLWSuoPgmvaVnQrLN1HzmN5eO9+gWf7pJdtlSCDDucb5I1TxjNoPsbpjD8im581bVo2 gE1zytDoWRI8cWDkLVBq5mlb3KDPppxS8LhexfdCpxSB5Fa0GXYZCjoBm5fCtoJkXxH5PrC FMWuPNlqgK3PIYqGCiWYA== X-UI-Out-Filterresults: notjunk:1;V01:K0:OyiI53Kzako=:WolcQqA6EeWeB+8VDLgari IKLxAs0iFkXsJUwh+rxj6BXZpjQKVRzI789Y8039TG824jd8+pgxWugogLLB/ehgvrwrcj4BW oK0ZECrXv2FDGyXpFiQh2CljCcsbRiuIqkI/wiGVq2KUe+CeRD5X3kk5aC6Eldp8x3IdsQGgN 7hkFtrfVlZxCKjHqztDzdxry0yJhda7q+nSRcvD1BsN9KsV6HO0fPP3j/WM5b/3XeGu3rFsBV qngsyS1go1bMlivsccyq2VO29oSsiajcHNaBdS87hvoGVcgJc0D9zTl2h/Qp2kLbMHBLa4TXO mptwAf7HU7y95mgucQazJLoiHPZZ5M4nYwsv5mxrhb/Y+SZDuYkqztO1Uxo5W9/JVVTsONv6E /hqxT8CS5aX66VrmmnLTjOEZchziO0zzGwpXwFPHNQSJK1EGlL7js6Ns/xL0IygE+ZBSk+Qoj d0YasEBxJbcRPTXDiS/TPvPr4Pe/4cWRYOF33x+xFGj40n57Bj7Wog+wU4UWPoqDZkgLdSdcC VGk/12O9mcKhbmg5brlvrXfvWLjn2MpMFGq8Bao9/oI7vJiqKGGqG/qmJidtWQAeJ8oZ7yfbG TXxB/Nkfbzh74MRp6RFpBmZEdJbsXMMsvZpNhD5Mhq93/DnDR4CuBkW+xnEXJmfs1fFAU3wA1 qzwRYu7ZurVOmXYd3Jl5tcK1b07mKD9YbyYeJMbcF5/Sm53o4NxRQIld/Zn7zE+QFAPY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Patch looks good. > Thanks! > Acked-by: Anil Gurumurthy > > -----Original Message----- > From: SF Markus Elfring [mailto:elfring@users.sourceforge.net] > Sent: 21 November 2014 04:17 > To: Anil Gurumurthy; James E. J. Bottomley; Sudarsana Kalluru; linux-scsi > Cc: linux-kernel; kernel-janitors@vger.kernel.org; Julia Lawall > Subject: [PATCH 1/1] SCSI-bfa: Deletion of an unnecessary check before the function call "vfree" > > From: Markus Elfring > Date: Thu, 20 Nov 2014 23:43:17 +0100 > > The vfree() function performs also input parameter validation. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/scsi/bfa/bfad_debugfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/bfa/bfad_debugfs.c b/drivers/scsi/bfa/bfad_debugfs.c index 8e83d04..a72170f 100644 > --- a/drivers/scsi/bfa/bfad_debugfs.c > +++ b/drivers/scsi/bfa/bfad_debugfs.c > @@ -399,8 +399,7 @@ bfad_debugfs_release_fwtrc(struct inode *inode, struct file *file) > if (!fw_debug) > return 0; > > - if (fw_debug->debug_buffer) > - vfree(fw_debug->debug_buffer); > + vfree(fw_debug->debug_buffer); > > file->private_data = NULL; > kfree(fw_debug); > -- > 2.1.3 > Would you like to integrate this update suggestion into another source code repository? Regards, Markus