From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752376AbbF3Mw5 (ORCPT ); Tue, 30 Jun 2015 08:52:57 -0400 Received: from mout.web.de ([212.227.17.11]:64552 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752184AbbF3Mwt (ORCPT ); Tue, 30 Jun 2015 08:52:49 -0400 Message-ID: <55929113.8070206@users.sourceforge.net> Date: Tue, 30 Jun 2015 14:52:35 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "James E. J. Bottomley" , linux-scsi@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] SCSI-eata_pio: Deletion of an unnecessary check before the function call "pci_dev_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546E441B.7040004@users.sourceforge.net> In-Reply-To: <546E441B.7040004@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:GiRAnDfXMzoeqeGIQAzkJL++0tsF6aH1hpmF6PXl9PRr+3+RjvL fmDVqIiFBnIq8qRxWbi/h0+DU4liHPOn115dE0jmpekYZ5ggzaXFfz7TyzUrx5FnheFqS1r zheiPmiaL1QLiVUa8HjZI4klDp/nVxLxjP38SE1iARUpp+ijVxYlcersVUAFxNK6E4eaH98 sprquSs07K+Ftbc/0wFhQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:YFbWdKHUrT4=:SzOmygFfofO15N/6bMCwj2 r4y93A0FI1uMkQcyFIyO/SYTLx7Q8bx9iDulxD2rW7tDgDThVsOkfooOoMRXTNQOzbxCQRhxb KinAXAZYMYNd3T4XuuUOz3mpSlVH4VWJpNfqo74J8OwiJHrH7WPhsI+Xr1q0V0DDWLKAv4/Gl uwIn8ABwxjE2VMpQvUDTJb86SiAWyOu7hXIpCdWv4gdbuacLISN3NCQRupnIWegr2jzogKyme SeF/6oYvZPhdOeLpgifUUSY3aO1gzYh6jvZrwdCf68ghmWpms7EHwNnGoJxSITB1Ytm/qAK3h OAH8pvK+O1VJ/FZruAuyYxfU+ofbtx2fPv5c65OJpOi9Id6c7oYdwle/OWW71EEV7uzxp/jqn pMfoqbtxlmjJTJy8PI7aJ8QEwhJXaEm3WabWYWJnM1v/uYA1eobsw9fPodP/rIn/FAgrt9Wm/ PZ6Vh49HCrSTXxj/YKLkcr0s5TN7Gq1+PrkgYhLWC/GAEidH0IfOifGI/KqlI4TAWdvIItrcH UiJ3inJSWi/8EJUuS9vqSIo/LxrUc6nUGPpiTa8HZ1kRaX/rEXt2IawJLSmRsOMwkZdKpw9g/ GWrpY3NnlMhDDrtm8VrH0/8gKsgdBkhztLW5YaMiHF47nMEl7qnWKFmxwguMYO81yqab8hTY2 lpUbuzzGAN20K3OF8FtN4Z/LUmHr0SCtXu2HRYGsweBXGkKBGTjoiwWE9OPeo54ENAzI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Markus Elfring > Date: Thu, 20 Nov 2014 20:37:30 +0100 > > The pci_dev_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/scsi/eata_pio.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/eata_pio.c b/drivers/scsi/eata_pio.c > index 8319d2b..707f64d 100644 > --- a/drivers/scsi/eata_pio.c > +++ b/drivers/scsi/eata_pio.c > @@ -122,8 +122,7 @@ static int eata_pio_release(struct Scsi_Host *sh) > release_region(sh->io_port, sh->n_io_port); > } > /* At this point the PCI reference can go */ > - if (hd->pdev) > - pci_dev_put(hd->pdev); > + pci_dev_put(hd->pdev); > return 1; > } > > Would you like to integrate this update suggestion into another source code repository? Regards, Markus