From: Stas Sergeev <stsp@list.ru>
To: Jacek Anaszewski <j.anaszewski@samsung.com>, linux-leds@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, cooloney@gmail.com,
rpurdie@rpsys.net, stsp@users.sourceforge.net, pavel@ucw.cz,
sakari.ailus@linux.intel.com, andreas.werner@men.de,
andrew@lunn.ch, ospite@studenti.unina.it, anemo@mba.ocn.ne.jp,
ben@simtec.co.uk, bootc@bootc.net, dmurphy@ti.com,
daniel.jeong@ti.com, daniel@zonque.org, davem@davemloft.net,
fabio.baltieri@gmail.com, balbi@ti.com, florian@openwrt.org,
gshark.jeong@gmail.com, g.liakhovetski@gmx.de,
ingi2.kim@samsung.com, dl9pf@gmx.de, johan@kernel.org,
lenz@cs.wisc.edu, jogo@openwrt.org, q1.kim@samsung.com,
kris@krisk.org, kristoffer.ericson@gmail.com,
linus.walleij@linaro.org, broonie@kernel.org,
michael.hennerich@analog.com, milo.kim@ti.com, nm127@freemail.hu,
ncase@xes-inc.com, neilb@suse.de, nick.forbes@incepta.com,
lost.distance@yahoo.com, p.meerwald@bct-electronic.com,
n0-1@freewrt.org, philippe.retornaz@epfl.ch, raph@8d.com,
rpurdie@openedhand.com, rod@whitby.id.au, dave@sr71.net,
giometti@linux.it, bigeasy@linutronix.de, shuahkhan@gmail.com,
sguinot@lacie.com
Subject: Re: [PATCH/RFC v2 0/5] Remove work queues from LED class drivers
Date: Tue, 30 Jun 2015 19:39:38 +0300 [thread overview]
Message-ID: <5592C64A.3020406@list.ru> (raw)
In-Reply-To: <1435672534-4004-1-git-send-email-j.anaszewski@samsung.com>
30.06.2015 16:55, Jacek Anaszewski пишет:
> V2 includes also patches for one LED class driver
> and two LED flash class drivers, that show how the
> drivers will benefit from the optimization being
> introduced in the first patch of this patch set.
>
> I was able to test only the LED Flash class drivers.
>
> Original message from the patch 483a3122 ("leds: Use set_brightness_work for
> brightness_set ops that can sleep") that was sent previously as a single one:
>
> Hi All,
>
> Since this patch will affect all the LED subsystem drivers
> I'd like it was tested by as many developers as possible
> to make sure that I haven't missed something.
>
> For the drivers which can sleep in their brightness_set ops
> (e.g. use mutex or gpio "cansleep" API) you only need to
> remove the work queues and move the code executed currently
> in the work queue task to the brightness_set op, as now
> LED core does the job.
>
> For drivers that are capable of setting brightness with use
> of MMIO you need to set the LED_BRIGHTNESS_FAST flag, so
> that LED core would know that it doesn't have to employ
> work queue.
>
> After the patch is positively verified I will create relevant
> patches for every LED class driver.
>
> This patch is based on linux-next_20150622.
>
> I am looking forward to your cooperation.
FYI I ported my soft-pwm patches to yours and that seems to
work fine. So I am looking forward for this being applied, then
I'll post them again.
Acked-by: Stas Sergeev <stsp@users.sourceforge.net>
prev parent reply other threads:[~2015-06-30 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 13:55 [PATCH/RFC v2 0/5] Remove work queues from LED class drivers Jacek Anaszewski
2015-06-30 16:39 ` Stas Sergeev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5592C64A.3020406@list.ru \
--to=stsp@list.ru \
--cc=andreas.werner@men.de \
--cc=andrew@lunn.ch \
--cc=anemo@mba.ocn.ne.jp \
--cc=balbi@ti.com \
--cc=ben@simtec.co.uk \
--cc=bigeasy@linutronix.de \
--cc=bootc@bootc.net \
--cc=broonie@kernel.org \
--cc=cooloney@gmail.com \
--cc=daniel.jeong@ti.com \
--cc=daniel@zonque.org \
--cc=dave@sr71.net \
--cc=davem@davemloft.net \
--cc=dl9pf@gmx.de \
--cc=dmurphy@ti.com \
--cc=fabio.baltieri@gmail.com \
--cc=florian@openwrt.org \
--cc=g.liakhovetski@gmx.de \
--cc=giometti@linux.it \
--cc=gshark.jeong@gmail.com \
--cc=ingi2.kim@samsung.com \
--cc=j.anaszewski@samsung.com \
--cc=jogo@openwrt.org \
--cc=johan@kernel.org \
--cc=kris@krisk.org \
--cc=kristoffer.ericson@gmail.com \
--cc=lenz@cs.wisc.edu \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lost.distance@yahoo.com \
--cc=michael.hennerich@analog.com \
--cc=milo.kim@ti.com \
--cc=n0-1@freewrt.org \
--cc=ncase@xes-inc.com \
--cc=neilb@suse.de \
--cc=nick.forbes@incepta.com \
--cc=nm127@freemail.hu \
--cc=ospite@studenti.unina.it \
--cc=p.meerwald@bct-electronic.com \
--cc=pavel@ucw.cz \
--cc=philippe.retornaz@epfl.ch \
--cc=q1.kim@samsung.com \
--cc=raph@8d.com \
--cc=rod@whitby.id.au \
--cc=rpurdie@openedhand.com \
--cc=rpurdie@rpsys.net \
--cc=sakari.ailus@linux.intel.com \
--cc=sguinot@lacie.com \
--cc=shuahkhan@gmail.com \
--cc=stsp@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).