From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753141AbbGAHuS (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Jul 2015 03:50:18 -0400
Received: from mout.web.de ([212.227.15.3]:49619 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751051AbbGAHuK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Jul 2015 03:50:10 -0400
Message-ID: <55939BA8.1090400@users.sourceforge.net>
Date: Wed, 01 Jul 2015 09:50:00 +0200
From: SF Markus Elfring <elfring@users.sourceforge.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Dave Chinner <david@fromorbit.com>
CC: xfs@oss.sgi.com, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: XFS: Fine-tuning for checks before the function call "xfs_qm_dqrele"?
References: <530CD2C4.4050903@users.sourceforge.net> <alpine.DEB.2.10.1402251840450.7035@hadrien> <530CF8FF.8080600@users.sourceforge.net> <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6> <530DD06F.4090703@users.sourceforge.net> <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6> <5317A59D.4@users.sourceforge.net> <5479F823.60900@users.sourceforge.net> <20141130230904.GF16151@dastard> <558D1833.3080009@users.sourceforge.net> <20150629214355.GE7943@dastard>
In-Reply-To: <20150629214355.GE7943@dastard>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:EGtZZzp/w/b1kzWc1SjreoE4mI+x6rmeNuPCaKHTZkG6gPomKAy
 tvJPoOH/vM522/H26uOU+yO76pFiEmJmBNfzQlTE+V+pw3magREtM8RJ6z9Ux9oD445Q8rt
 TR1aNsiBNFta3QTsem3CL0bJVep6bdg44fzlHAt2ay26R0x9CTOzj4RbjBotUbvLeWe8x9/
 e92ESvmEK7++GSInqlUiw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:tMfjTxOIgJw=:/hqXGBZJRITeVEXzXtk4mM
 nOHXdPYYoHlMTgcaBLkFugQdZ6gB2SrlLYkN7hVwEjUWfEDdi4gr8b/yJ6O6hPyQlLlgMsNS+
 LEY38dSql/loztpPsobUHxaMaNT1RVCu2JwVU2MbtUStCq9TJgqVP/OsIa2q+ru/xhwh8s8GJ
 smvD9YnLqhavBqeipiY0EJRYwQrpdLEQsE3LhAVMmaJ78rZrQegNG3dy06DMPywK1iCFGU8Lg
 6j66JyNzOYTkutuqzZ/2pp9QYeHLaoXoHN+GSJYKJD3P6seLJiZ0U7DaZG/dFV8gbHHg7tQRZ
 pyxRKwIMFFYGW5vyK4/nbLuvEbD8DFMICpvwGq5XDdpHbwWEcQFaWMTmIhVdZK5IK8To1CqpK
 pJcJP3jdyXAyYCaEreN9iXh24ZYWFooW6JPIOlivn7/W01nd7vrYEbwaScCoYAvuvepIoq9mW
 rVpIgCMm75THOSRD8G4stIE2SGnAC7V0gDFuVpj6XiYEypcCSedM5DQuuPkAi87CcOEkAGGx4
 JQhsNzjYg3hhXAQlzM22SWJ5M7oRzFoTCYn2tTqiR+D2FM21Juubx9Z52Y2ijFtIMNAQcJXxT
 NtWZsG44mYVBvSHFfuByAZeRlOv8EQEH/IFl4K8itHcow5ZMI1b1j+uyWXBBPg5c17m3kDKLZ
 eWbr43H61pQWIabogStDGlBLZ+PMVlraSE+jiPOHc38th+OEXviFA25AnMA6cjk8ViZY=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> xfs_dqrele_inode() gets called on every inode in the inode cache,
> and this change results in a cacheline in every inode being dirtied
> even if they don't have dquots attached. Given the inode cache can
> hold tens to hundreds of millions of inodes on large machines, we
> don't want to dirty any cachelines we don't need to while walking
> the inode cache and releasing dquots...

Would it make sense to annotate checks before such function calls
as "LIKELY"?

Regards,
Markus