From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752923AbbGAIvD (ORCPT ); Wed, 1 Jul 2015 04:51:03 -0400 Received: from mout.web.de ([212.227.17.11]:62869 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbbGAIuy (ORCPT ); Wed, 1 Jul 2015 04:50:54 -0400 Message-ID: <5593A9E1.5090206@users.sourceforge.net> Date: Wed, 01 Jul 2015 10:50:41 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Hal Rosenstock , Roland Dreier , Sean Hefty , linux-rdma@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Maninder Singh , Akhilesh Kumar , David Miller Subject: Re: [PATCH] InfiniBand: Deletion of unnecessary checks before two function calls References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546CE09B.9090101@users.sourceforge.net> In-Reply-To: <546CE09B.9090101@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:rk6y6aIZLOVzIxd2q8PTgZoJum2wyc5hDV4YKZb5Smn0iZFZsc/ MlVQ+hxKEmKGiKSCqKssruHSxNMpy66phNscdK+DWgE1M4Ne8mpm39GfqAJdRS81bMzHgVN C9Me5N0ctpIbWP1Fsllww5JthNeK855VmnzaNs2CmfjZhL+HJEGOhW4xpF0t9KuYClZDwTp 4XTg2Xsj0/lbV6QCXulcg== X-UI-Out-Filterresults: notjunk:1;V01:K0:ZI5YLlHtRA8=:rkDIazklc3vtz67YPOgsfQ +ZRIV7ELQ+8/usMrQS39YPGsRNSGGS5RwE2dObRBpgnNc7DW4PuTdHTSo7LUe09D8MMV5Papx JFsTvJaHpCgKoBA2ef/uy/lFZ8R9aVwPvUAlkSdkj+Bdl8uiYf05XcfOqs31LCxry387Ahhu4 lX3tVFbFEAyBDQp0w2+LvP9L71ytGbMd5fHwIlM/gh2+TaGwiX6BFZpgLSR6iDUaUo7Bkp94b GbQecVgRYo6nIFa76ekkUYEcpczKi10PKwAoRStwxOKfs07QeTkkR6oCUcqgKQJG+T15yOcvo W4LeI2GnaAJBkyXw2HvFUNXSypojGhOu0nD2Tn535h1kms8AquZlLQOhfV5NL0/WQbSiXoBvW wuCarmeUNJRtAgKFEWuLanFWFOSJNyuKb/U7aU0O8J95qZuuV0Wc/E20T13iRhuAtwPeMReG4 tp+qduf+Pqb5NXtzLgb6ErCOH0Ce19pT7iLQUNc9zdcI49DrXP+uaCTQu8J9EVmYxeab41UZr B5dPRnCsC9x32kFhFic3DyqLh23G50C4h3vlzoU5nYr0x9oYPs+nPhKYkZpmbL1NRB6ydbMMK tx6qS5AgCsMR7/gndUQUbRBdBg2cxAxIS3jv0NIsnbrBg4OVCYMYSt4oMoVaDPZVVq5Wt00ig 4HiMKxoHriKTdMbs8OUT5shrJIxzJeMQmNbw2DkD31+6pRKxydOr0OTVJDDZ4GEU9gVU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Markus Elfring > Date: Wed, 19 Nov 2014 19:19:21 +0100 > > The functions kfree() and pci_dev_put() test whether their argument is NULL > and then return immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/mlx4/main.c | 3 +-- > drivers/infiniband/hw/mthca/mthca_reset.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c > index 8b72cf3..50dee1a 100644 > --- a/drivers/infiniband/hw/mlx4/main.c > +++ b/drivers/infiniband/hw/mlx4/main.c > @@ -2512,8 +2512,7 @@ static void do_slave_init(struct mlx4_ib_dev *ibdev, int slave, int do_init) > if (!dm[i]) { > pr_err("failed to allocate memory for tunneling qp update work struct\n"); > for (i = 0; i < dev->caps.num_ports; i++) { > - if (dm[i]) > - kfree(dm[i]); > + kfree(dm[i]); > } > goto out; > } > diff --git a/drivers/infiniband/hw/mthca/mthca_reset.c b/drivers/infiniband/hw/mthca/mthca_reset.c > index 74c6a94..c521654 100644 > --- a/drivers/infiniband/hw/mthca/mthca_reset.c > +++ b/drivers/infiniband/hw/mthca/mthca_reset.c > @@ -279,8 +279,7 @@ good: > } > > out: > - if (bridge) > - pci_dev_put(bridge); > + pci_dev_put(bridge); > kfree(bridge_header); > kfree(hca_header); > > More software developers became interested in similar source code improvements. infiniband: Remove redundant NULL check before kfree https://lkml.org/lkml/2015/6/26/45 https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg919966.html Regards, Markus