From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753854AbbGAKar (ORCPT ); Wed, 1 Jul 2015 06:30:47 -0400 Received: from mout.web.de ([212.227.15.14]:55700 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753572AbbGAKai (ORCPT ); Wed, 1 Jul 2015 06:30:38 -0400 Message-ID: <5593C14A.8020700@users.sourceforge.net> Date: Wed, 01 Jul 2015 12:30:34 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Lee Jones , Jingoo Han , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org CC: Linux Kernel Mailing List , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH v3] video-lp8788: Delete a check before backlight_device_unregister() References: <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54720DEB.4060109@users.sourceforge.net> <20141124101006.GD4241@x1> <5473736F.8070705@users.sourceforge.net> <558FE386.7060704@users.sourceforge.net> <20150701080612.GG3210@x1> In-Reply-To: <20150701080612.GG3210@x1> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:q0ngW4DJkKuXWK4be3EW++aUpwRqZGxXg0LThvintKGmi3NugXP tykQ4q2SKM47YeKOB/65h+CzaLdIKGiTlSM4Wp5/xFzPAUVncieaAyh0ZljIKJ3UjUn72Z3 JPaNf/KJ6eABEJiGUZ4rW7KQwNbIsjyaoi183V79iSoeYNbEV2jYcWwZjgXYqwo76UVHAsy e/Ny0QfA35IQ/j7N98rtQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:MHfinORortI=:scD6iDtEgxA1tduyomRb/X ApVr7e/+Ga4Ujoo0eT12Ljms/fuMFg/YQl01RVjlGNQEIB7wqN7Zlps1uORDja7iXGQJXE7ZK KUZYqiFxPTmppmurBnNhZesU3IBS7EZqOeQMnCHjMSBKDcwDza4JWc9SoDGQO5d2KbL0DSfad srt28RNAzAg7MBJ4iJi2ZdWxZDZ/NvqXQiSfyYQ4cq6XQgqUg3NYxz/yQup+gJSiZEEGC+coN CCQhyMO1qORyhL0nUF5vDkSucT1Wbhmq9fQJx+4VOqPA2V0dVy909Sx4uexEDKjJqanFUHq5T Z8M68wJiGfont57P6DWceJnP05qUEWfJcR24+infBK/YZr1RNM1rr/tc6ZVPpLQDUXNHbDPeX Zf5Yx2HqT6R1AgQ7j9qlc1ez1NfRYLHgz+zV37o+GzV0csnT1T3Q+dgX/fULPebLHS0aAQywx oYZXS/F2E4cyADeqhRV5Um34emZDP19x7+qFI+B7rCT4E1QYBUPLqx+rUsMfPb/59HKuSq0yE cu9p9xRU9YB0dFBuuDX1Nz434hu2omAHdUZK+E21iJFZpKpmAcmCUm2diDh2M71BtsySSJXT2 xvOKL/hRT9yHKoHUiFOeZIq4Ix5tcAXYD/K/aJVSVUa0hVUo3QDaId7pTkbcJCwYBAtH7Hzno ZmZmkUGSqjENGl4ZDuuckRjDw06lq4U6B8MmmZaBO4pGd5FAZ6WtsFB62UO4f4lBsUpY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 1 Jul 2015 12:08:31 +0200 The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/backlight/lp8788_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/backlight/lp8788_bl.c b/drivers/video/backlight/lp8788_bl.c index e418d5b..5d583d7 100644 --- a/drivers/video/backlight/lp8788_bl.c +++ b/drivers/video/backlight/lp8788_bl.c @@ -221,8 +221,7 @@ static void lp8788_backlight_unregister(struct lp8788_bl *bl) { struct backlight_device *bl_dev = bl->bl_dev; - if (bl_dev) - backlight_device_unregister(bl_dev); + backlight_device_unregister(bl_dev); } static ssize_t lp8788_get_bl_ctl_mode(struct device *dev, -- 2.4.5