From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753037AbbGBOoH (ORCPT ); Thu, 2 Jul 2015 10:44:07 -0400 Received: from mout.web.de ([212.227.17.11]:52126 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752614AbbGBOoE (ORCPT ); Thu, 2 Jul 2015 10:44:04 -0400 Message-ID: <55954E1F.6090205@users.sourceforge.net> Date: Thu, 02 Jul 2015 16:43:43 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Alexey Kuznetsov , "David S. Miller" , Hideaki YOSHIFUJI , James Morris , Patrick McHardy , netdev@vger.kernel.org CC: LKML , "kernel-janitors@vger.kernel.org" , Julia Lawall Subject: [PATCH] net-ipv6: Delete an unnecessary check before the function call "free_percpu" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:3RcfIjdSfpNb2T+p7QhOZnsQ2f+CL+bxmolrNBuhwYmSJ5oKtEv AqO74xPe292PjIEe/Ft8DU1nXSjBDCmeKoU7mzTazx/GO/5RvcWhL34DDd8hG6ULm0JsfiK Z2gNpJyCeOtCHo5q9OBQRvNxJaZKnqcLRxMQkJ2rGz4GOzPJsi3tz+b+rr63ndeLnzsd3/e x+XkYRNYanUNoW5pfTp8w== X-UI-Out-Filterresults: notjunk:1;V01:K0:nk0xAfTDT8E=:3LILuxaInHM7T9TXVa/wB4 sITjyc3fmut91sQIKaTrs22gB1Pt+48xSfx6P3f6DoOyaY8KR93IAt7OsdRYL8rcvBtvwEN2z lKZpBuSmblTf3ZDQrr2Kj3U5KiyzmGF+6mkLE+MSHAwTuoKuz3dOpYVq6a7sY893mOeAsB3gM XVy1w+VMGdBwxY1eRmayBxshlxdM3WrkAd/+l3VsIA7ZflrTFMbrcUInSgOLdgCj8PSL+Ywvn wzUx1MUZvj3QP7gNfEHdB89PN4p2H3GMdm3qsjxVCklKEBKdzeQgPH8L3Ilx+fOFfJrJN2Plr X01j27Ez0xfYz+4r2LGOBo/KGkvmJQ2Cs+C9ITs4HQsHT4JXCdJVlPNxTERkRsDIGZnpm6/Nb 5rTTZDzad5LHnYRhW1WGqkzEPIjsJW0LIlC73Gz9ZDkPN/rX++oaB4uhdIwJudhPTzEJvS2t6 +n5f4OHiQf615lqwLJwFMzYrBV3b8VcHC+Y1f2sfmoHLAJw7OUBLuIGm1NiaRPhbq2jyS3Lj3 1QLRxlDW3JLYsj6L+bpYP1C1RU9WnVysPKn2ep1zW42jJu6wviY2E20fN2csB5pZrKUHG3egk 8utNvqzb793QQ+gIwLY92G8FKhO0P5KCrR44z5kMNq9gBf8HYpSTOadqmdb+HIjSpHTVhmmol jyVmyssijLgUz3s90CTGEqY7l+U/YWSGlM8/sm4W4QFrPJ1OvNabAwrVPbz7A4/2FEbU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 2 Jul 2015 16:30:24 +0200 The free_percpu() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/ipv6/route.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 1a1122a..6090969 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -369,10 +369,7 @@ static void ip6_dst_destroy(struct dst_entry *dst) struct inet6_dev *idev; dst_destroy_metrics_generic(dst); - - if (rt->rt6i_pcpu) - free_percpu(rt->rt6i_pcpu); - + free_percpu(rt->rt6i_pcpu); rt6_uncached_list_del(rt); idev = rt->rt6i_idev; -- 2.4.5