From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753791AbbGBQIz (ORCPT ); Thu, 2 Jul 2015 12:08:55 -0400 Received: from mout.web.de ([212.227.15.3]:62114 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753790AbbGBQIl (ORCPT ); Thu, 2 Jul 2015 12:08:41 -0400 Message-ID: <559561F3.2040107@users.sourceforge.net> Date: Thu, 02 Jul 2015 18:08:19 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Chien Yen , "David S. Miller" , rds-devel@oss.oracle.com, netdev@vger.kernel.org CC: LKML , kernel-janitors , Julia Lawall Subject: [PATCH] net-RDS: Delete an unnecessary check before the function call "module_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:3UarkgyM9NChzSu2zSlgMLlle/uZhXQKk+JMe9QwdgvFXiIEbHs 6+l4UwRlh8+wpHKoNJpP/PNt4L41RxAe+xJjuk1lHJFyT/sn8+BjhYbnTW/fwhr6ULecKuu XFCdPv6tp1NgQjbv0lOWw+tLpp3pA+upihBZRm/VyJDQZ3wUW5RflaJHuQXhFDKqhZJEGow ikuoWBRfu0cOJN+O44qBg== X-UI-Out-Filterresults: notjunk:1;V01:K0:CCpNPilMycs=:obd9L+icpv3mPISpZM4JvP 8LTQs3/WLcXuukyNw7GeEyFqNf9eOGGuQkYRUZRELJHhUgh7xG3oA5e93gNDWjlFs/1D490Uf srorG2a+HK+DcO2SQ73laTQuPRZFPUJ/x+N4ilX/BYQ8SHRiHbpf75XZECjk2iezpKDFQYWft lGZW25++Q0l0xrP7308ekub+nZC8TL81tsVksNVGXUrhwPsciKZT9hFF+4kiTp/Ki7bQvoNcy Xkg1yBKme+bLNxh8SE6AaIF3jHBgY4AyhXf4cpff6tOS91rzvLGt4XT5TfC9lzfpAqeR9thP5 pCqIMfyOHAZKKUu0GK8FTJC1Fcu9y7c4/6WxTvMa3rradAmVDgD2oi2G4pXtnxcdyxLg9J+vM a9sqYd5heBpIJp2ZlZexCqRPplAlAeuITpXSWQaQlAGOkrXkaX4jkVjSXW6/cDR9Q+Rn8mL+Y XkwzeOQ3fzOaY+kZuf7bn6seAQ+4A/U5ze4FpDgP8VnftB2ZVPbO3DBNYM8iOR3iiA9zgPIPS NdVKLUnzJmC4NRCs1eFVCxB+cQwWG5e+nOVNkChepDx7NOp2YK7iGD4Y4GCzPav4CbP8JDzWe n0rw8cJZXNqLgq+XlXsNaGRFF6Ys4jsfVep2y5GJoCRy1uR1yV2vGv6XQfoXDPsNCe+oSfHbU lg8yEF+QbEG67JOhlUEcRUaP/S3fkiT7E9anUN8M4qNgcMcrzmFYvyk6YRgu2WP4Yohk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 2 Jul 2015 17:58:21 +0200 The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/rds/transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/transport.c b/net/rds/transport.c index 8b4a6cd..83498e1 100644 --- a/net/rds/transport.c +++ b/net/rds/transport.c @@ -73,7 +73,7 @@ EXPORT_SYMBOL_GPL(rds_trans_unregister); void rds_trans_put(struct rds_transport *trans) { - if (trans && trans->t_owner) + if (trans) module_put(trans->t_owner); } -- 2.4.5