From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754055AbbGBTDL (ORCPT ); Thu, 2 Jul 2015 15:03:11 -0400 Received: from mout.web.de ([212.227.15.4]:57313 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753357AbbGBTC7 (ORCPT ); Thu, 2 Jul 2015 15:02:59 -0400 Message-ID: <55958AD3.5070507@users.sourceforge.net> Date: Thu, 02 Jul 2015 21:02:43 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Dan Williams , Linux Kernel Mailing List CC: kernel-janitors , Julia Lawall Subject: [PATCH 1/2] tools/testing/nvdimm: Delete an unnecessary check before the function call "vfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <559589D3.8000709@users.sourceforge.net> In-Reply-To: <559589D3.8000709@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:3J7kuyhPQZkXgpMYTKgGEFWzWQxblUF61Qp5ed6a5VcGZNkLQte j2LxEBA4SKSfhB/jekBbGQAICHeEY8Rezx8He9vFQ5lCwK9ZedJW0pTnFnVf9gaNbfOb4ZM BeIgpDHOjRVzOiFhDNP1LbwymH6NXUh/qI2Mn6+Jhx9ci2IvHqmqPWvevT+xutzkAMFtnSF Ux555tlEpwHlVrwU+9OWg== X-UI-Out-Filterresults: notjunk:1;V01:K0:NVwbhz29DL4=:sQroySIALbvkWfeX3QxoVG /l2xE4td8IOpQ/ALq4XObADh8rQ1WRfn4T945+1eHduTgjTaY/Ux9RnyWRWuolMNDg4ydgBbx ebrDtf1v2kAssQqNr2AAgqGuohfB7d92cdJuTm9+xqpFLrqgg5/9fyzgkmhKJItYzpY/4mf8H q+f967JwPIQNvMF0kD+C8mjdV2LBeAiS63y4XDkENfWtHBjuUJXd4zU3+Ti/mUN888y0t9XmK yLOgkI2fxALh5bRkvCgvoN0+utBUEcJyd2qwC4HjCZhcmk0L5cUb6ukUzcuNXqGxhd+gCNSpp QyQ1rF2JvIuHzVAzyT40a+Q9t30DP9Fq0HwiXcheBxtcnz1/z5ckQ89MaGfb7dPCZHPnPDDNY OGqxbuwjSKCTIaSSsMAJe5CEy8zHOOGBG5vz+nbof3Y0rbzNVGS/yX6ZcG61flPgiq0Vl0YEY ku4L40QbGDp50lZ27qIUCrdX3vBOWhKwY+qkdSiwg5B0UB7MkNqs5L+gVN+mn1noOWqsqqPAO oxE6wTAcT5VYhviAQBdBMOa64oiMHYsiKGfL1KtbskgsOsKvlE29CodZIbFmqtd8lyAkcFT0W jnal4QZOiwUCEutnxpYNxX3gmFocWWTNosCK9LviRmoE/ybBL2iSf0tw1UWJStM0kTNM1Z3WP 6ndajr7qq5scAut7FtxH3vEabtr4hoU/yGndoBlJVkIkvhYo3hvgyb4QFlb264ezy524= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 2 Jul 2015 19:24:27 +0200 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- tools/testing/nvdimm/test/nfit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c index 4b69b83..9c910f1 100644 --- a/tools/testing/nvdimm/test/nfit.c +++ b/tools/testing/nvdimm/test/nfit.c @@ -270,7 +270,7 @@ static void *__test_alloc(struct nfit_test *t, size_t size, dma_addr_t *dma, err: if (buf && !is_vmalloc_addr(buf)) dma_free_coherent(dev, size, buf, *dma); - else if (buf) + else vfree(buf); kfree(res); kfree(nfit_res); -- 2.4.5