From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755844AbbGELkR (ORCPT ); Sun, 5 Jul 2015 07:40:17 -0400 Received: from mout.web.de ([212.227.17.11]:55570 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755576AbbGELkG (ORCPT ); Sun, 5 Jul 2015 07:40:06 -0400 Message-ID: <5597B0A9.8010308@users.sourceforge.net> Date: Sat, 04 Jul 2015 12:08:41 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: LKML CC: kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] fs-notify: Deletion of an unnecessary check before the function call "iput" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5479EAD6.1080706@users.sourceforge.net> In-Reply-To: <5479EAD6.1080706@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:yMBemoqohQ3Pt/XGISIPYdHmfiQZltMe4i4KgcAcKtyOGvEZ2OD +Z6GmBP+mrffeMDCj2QgaUjM8Hh87cqwXLoteX3osSKk1xVk4dOc7ZWmEwq7NoMxelrQE4v WTE0LBVud4vZAJGZSycJ+dayPoay6Ct+RHc/hEv5sq0C6amKhBH4smwE1kZpWu02fvA9nNi hGvUzfUqdHN1g7uiV1i9A== X-UI-Out-Filterresults: notjunk:1;V01:K0:0jKgL7bDfkc=:83rwYGhFtiJE5PXV5wz21h uoZIvTrIjn975SuBT7RZajXFaR4ePeciKMT3uUl7mcyjSOZKJC2Sw4917LXx2jw9alcfmDutB 0Ytr3gUVAjkLu8Tf02PLvqWqg+FOV6dFdNzSMX7ZR2i6BL7R1Lxohi82Cqv6bDLkcLBf3ps2z fzFIuj0K/gc/chABCjhExVAff9Oh8bFadjN85Pwa4EgVXtYcXR/2DQdi9wCcVwdplR6cyEjK5 /filYp1RCS7Nn8Aw4x2Ob/9VHu8vuVYnXVo22KYIYJh17LYvXkLICBcnP5npKjfFJsPIAAqmV UUp4JwZhoyR6u9Fd3fHhyYM1g08QToOXgdp28P7fvd/vlfPS1woDI5m9tQe2YfD00vFEMcGAG dt7cMufC7Lq1gfbd1l++kSvF3hiSQSz/LjFOdNPviP/SktbaHSAL10LgMrkBFaTPy3wkEIzpb /K0lk2qG31h4EZ0kT79j+kABf2aTPyRPbPJOjz0wKKO0GQetL4CPlfX+kC8Vppv+8IJq1XuYJ Itd734Io5IrWldPla20dylgZGHMwRutWVNawHMkq4ohiZbPO5tOXVXOeYbLtqsLNy58+REMfj H4cwIj6JW1KhTr+2alkFTwWo3Zc23PS0Co/RKVLfukJmE2zm0GWC+YpXwXz/RYrHXpkQzGz6m DZOjNG6fbzlIEW1iFp65dOaQOn+K7X5+HgO++DvuEB5f6OnKRn0E2dHjsjfcEMewKC00= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Markus Elfring > Date: Sat, 29 Nov 2014 16:42:50 +0100 > > The iput() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > fs/notify/inode_mark.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/notify/inode_mark.c b/fs/notify/inode_mark.c > index 3daf513..d8157a6 100644 > --- a/fs/notify/inode_mark.c > +++ b/fs/notify/inode_mark.c > @@ -231,8 +231,7 @@ void fsnotify_unmount_inodes(struct list_head *list) > */ > spin_unlock(&inode_sb_list_lock); > > - if (need_iput_tmp) > - iput(need_iput_tmp); > + iput(need_iput_tmp); > > /* for each watch, send FS_UNMOUNT and then remove it */ > fsnotify(inode, FS_UNMOUNT, inode, FSNOTIFY_EVENT_INODE, NULL, 0); > Would anybody like to integrate this update suggestion into another source code repository? Regards, Markus