From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751130AbbGEN1W (ORCPT ); Sun, 5 Jul 2015 09:27:22 -0400 Received: from mout.web.de ([212.227.17.11]:49434 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbbGEN1O (ORCPT ); Sun, 5 Jul 2015 09:27:14 -0400 Message-ID: <55993082.9000401@users.sourceforge.net> Date: Sun, 05 Jul 2015 15:26:26 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Joel Becker , Mark Fasheh , ocfs2-devel@oss.oracle.com CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH 01/11] ocfs2: Delete an unnecessary check before unregister_sysctl_table() References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5455FC05.4010606@users.sourceforge.net> <55992DF0.5030205@users.sourceforge.net> In-Reply-To: <55992DF0.5030205@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:4yzqqgut3LEDdHUJfZ+os8AEeM2acUJ8tolBFuKuOtMhr0lQutm 6eI/BylDhY4S4YrV1+Ae081QFcUbic7tEE9RoDzVhKni2W7veUumwGYFLePTGurc1g1bJwC A486WtO0DNqe5DYWWNA/M5qmwyIa14LV6XrHP/3j4WrFch/8V/urrkfT7C3SPoUkB6FE5fe cl6RnsiRaXhn6PExEFNcA== X-UI-Out-Filterresults: notjunk:1;V01:K0:xfjpsWce+Go=:vx3zXhkctxRpDVdZkW3I+H a1yBQyH+GMUcKWu/Y91UY5vjsxtsdDPYux8KD0WkWsjhId7lFgAgOJhFihXA20Y+F6u35MuAc FL8huvywncVHpoo48FUsF2FSku/JYRKdh7tpUOVucewR4GnII+OCma23/JH/GXyecvKLXt1nU rM25Bx89H8RqNZh7EvLvmDNEk4xqopv4Y1vntcPsc8TigyVJ4bHiOMoMpz/FMl7peHOlw4/wt Man+VKiHalgDzOvjgiMw35I1WGAyxILlyxpdUG/f2AKKKkC0hGQtcQ5wRYs4f7WwihwTrHn4R /5c2u2Qu+3fZI63bqEQ4X5kIs6hLTg/eCq2HPqg556UL3qn7Zpaij1ARvEbRR2F19L6SIMDV3 IlOnCSRQneK6s23UAWRWAetYpln49LL4S3t0vmDaUQpiJ4c+O1sxVK0IfEekjnBKYUKc5/AF9 yXXxqu+weneKnXHV+2n0/FjP3L1BdixofkUTs1Sqps2zeVb7G70mr9+jpTwmYqypUYmi7/joQ 0X9cqeZG6SspDlZ8n7jY57vvrTO0zKD1KLM+hzie54GHjqO7z6RK08dqw0NpwCdnhRI8FtMXA 7AH/cOEauTe6RB9/Bz0AG9t1YPDnnJ9tlOdDMNAu8s7mz/l9M0n06EjpQMA7oNO+/XF+4R1R4 Erwc2iW6PWWy74r1PCUniFOxrWj+KjrYpteH93A8vAyHCCzvkztq/3sXimMa52mPjhyc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 4 Jul 2015 13:20:13 +0200 The unregister_sysctl_table() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/ocfs2/stackglue.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c index 5d965e8..4222f93 100644 --- a/fs/ocfs2/stackglue.c +++ b/fs/ocfs2/stackglue.c @@ -737,8 +737,7 @@ static void __exit ocfs2_stack_glue_exit(void) locking_max_version.pv_major = 0; locking_max_version.pv_minor = 0; ocfs2_sysfs_exit(); - if (ocfs2_table_header) - unregister_sysctl_table(ocfs2_table_header); + unregister_sysctl_table(ocfs2_table_header); } MODULE_AUTHOR("Oracle"); -- 2.4.5