From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754709AbbGFLYr (ORCPT ); Mon, 6 Jul 2015 07:24:47 -0400 Received: from mail4.hitachi.co.jp ([133.145.228.5]:55792 "EHLO mail4.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754042AbbGFLYp (ORCPT ); Mon, 6 Jul 2015 07:24:45 -0400 Message-ID: <559A6575.9080605@hitachi.com> Date: Mon, 06 Jul 2015 20:24:37 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: SF Markus Elfring , Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S. Miller" CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] kprobes: Delete an unnecessary check before the function call "module_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546899CF.8020808@users.sourceforge.net> <5469B08E.90104@hitachi.com> <546C41EF.4040502@users.sourceforge.net> <546D65C6.3030109@hitachi.com> <559794F9.3050800@users.sourcefor ge.net> In-Reply-To: <559794F9.3050800@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/07/04 17:10, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 4 Jul 2015 10:00:26 +0200 > > The module_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > OK, looks good to me. Acked-by: Masami Hiramatsu > Signed-off-by: Markus Elfring > --- > kernel/kprobes.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > index c90e417..52e3529 100644 > --- a/kernel/kprobes.c > +++ b/kernel/kprobes.c > @@ -1531,10 +1531,7 @@ int register_kprobe(struct kprobe *p) > > out: > mutex_unlock(&kprobe_mutex); > - > - if (probed_mod) > - module_put(probed_mod); > - > + module_put(probed_mod); > return ret; > } > EXPORT_SYMBOL_GPL(register_kprobe); > -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com