From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752792AbbGFPQF (ORCPT ); Mon, 6 Jul 2015 11:16:05 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:52245 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800AbbGFPQD (ORCPT ); Mon, 6 Jul 2015 11:16:03 -0400 Message-ID: <559A9BAA.2010400@ti.com> Date: Mon, 6 Jul 2015 18:15:54 +0300 From: Grygorii Strashko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Alexandre Courbot CC: Linus Walleij , , Sekhar Nori , Santosh Shilimkar , Javier Martinez Canillas , Linux OMAP Mailing List , "linux-gpio@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: [PATCH] gpio: omap: prevent module from being unloaded while in use References: <1435245213-17858-1-git-send-email-grygorii.strashko@ti.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/30/2015 04:52 PM, Alexandre Courbot wrote: > On Fri, Jun 26, 2015 at 12:13 AM, Grygorii Strashko > wrote: >> OMAP GPIO driver allowed to be built as loadable module, but it >> doesn't set owner field in GPIO chip structure. As result, >> module_get/put() API is not working and it's possible to unload >> OMAP driver while in use: >> >> omap_gpio 48051000.gpio: REMOVING GPIOCHIP WITH GPIOS STILL REQUESTED >> >> Hence, add missing configuration. > > Isn't this also fixed by your other patch "gpiolib: assign chip owner > to dev->driver->owner if not set"? > > Nevertheless, > > Acked-by: Alexandre Courbot > > For inclusion into -rc if the other patch is for the next cycle. Yes. I've sent this one for -rc as it's 100% fix and was not sure about destiny of patch "gpiolib: assign chip owner.." :) > >> >> Cc: Tony Lindgren >> Fixes: cac089f9026e ('gpio: omap: Allow building as a loadable module') >> Signed-off-by: Grygorii Strashko >> --- >> Hi Linus, >> >> Seems this one is for 4.2-rc. >> >> drivers/gpio/gpio-omap.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c >> index a0ad803..61a731f 100644 >> --- a/drivers/gpio/gpio-omap.c >> +++ b/drivers/gpio/gpio-omap.c >> @@ -1187,6 +1187,7 @@ static int omap_gpio_probe(struct platform_device *pdev) >> bank->irq = res->start; >> bank->dev = dev; >> bank->chip.dev = dev; >> + bank->chip.owner = THIS_MODULE; >> bank->dbck_flag = pdata->dbck_flag; >> bank->stride = pdata->bank_stride; >> bank->width = pdata->bank_width; >> -- >> 2.4.4 >> -- regards, -grygorii