From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934768AbbGHIk6 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 8 Jul 2015 04:40:58 -0400
Received: from mout.web.de ([212.227.15.3]:53054 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933616AbbGHIky (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 8 Jul 2015 04:40:54 -0400
Subject: Re: staging: wilc1000: One function call less in mac_ioctl() after
 error detection
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <alpine.DEB.2.10.1402251014170.2080@hadrien>
 <530CD2C4.4050903@users.sourceforge.net>
 <alpine.DEB.2.10.1402251840450.7035@hadrien>
 <530CF8FF.8080600@users.sourceforge.net>
 <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
 <530DD06F.4090703@users.sourceforge.net>
 <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
 <5317A59D.4@users.sourceforge.net> <558EB32E.6090003@users.sourceforge.net>
 <558EB524.1050609@users.sourceforge.net> <20150707023150.GB22043@kroah.com>
Cc: Chris Park <chris.park@atmel.com>, Dean Lee <dean.lee@atmel.com>,
        Johnny Kim <johnny.kim@atmel.com>, Rachel Kim <rachel.kim@atmel.com>,
        linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
        Julia Lawall <julia.lawall@lip6.fr>, kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <559CE207.5000507@users.sourceforge.net>
Date: Wed, 8 Jul 2015 10:40:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.0.1
MIME-Version: 1.0
In-Reply-To: <20150707023150.GB22043@kroah.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:Ry9EFqp7YJ7Lj94SGEP3pRjIrf6Y6yBFYJxI/+4GacEKuAlAlkT
 DlnRW/KDu2r/EC2iNOqDS8uCZ3P3W0yJu1030D2Coo3HcqMpnkxe/hYJBVTYRn83BBIn/PG
 Nc/kxYPwNm9hBzkL5E1vRmaeYxfSxgImPyldxhd3eijZZsbPG9taaRMtn0YjtwiMx7T8hCn
 UO3UHS2EIoxuGvafn/YSA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:TbDulgERiNs=:dPxtAHC/RwgvECFgAL4wYC
 fXE6aYoDtLCnsUQCHB5mYHYbde0JphJZmxcOr1nvohEYPv5C8+ZcEDwwv78Qtv0EcFza99+cZ
 HbsnbIUz2oVaGlzeTCQ/qdlyPhQcZMpLuxHYvuYlgdpG+PBCz8K1K7ZduCMXI/yW4XbJxdcCG
 8BrvVwWFkp1uTJae+XLi+l/jExuPB6kjwyDkjj8oeQf4DXpvx+lF3QG3lJArY9Nd7K1JF87bT
 3EU/cUtYeB0HX5YZWKakVzPpnZluLYzQiRtPdZHe10o+VNRDoxEdIaA/COGxBCs5mJByHCFqL
 8FwiV1WidRxlAex2vBH+h5MCH1hq07xkfnnvvYnpQznlebMAL32fKPnnjfkMOw9n6TypnOF6v
 LNvqAlz9mdFV50KKcfxOc7djITqBB2bLDqMH6gTK+8J9ciu8w1Fwb6FLmcdTm+cg5/TLstC3w
 XTWDcVBBlJZ2Jn7CCedcC0vNegb80WbcTB/FrRWV0X4PKCfHpM1x+nlQTxdInOP8vJk6IVZ/3
 wWLTui4xk7iShqp4z/5A4HM8EJYxT1sBwuFpdc3WPMXfB8mr+bhoBoqsSAvZbSRbQZDQsHnH/
 2kkjWnUWZ47W55SgiA9UJgSvLPRqyWpjhHTeW4AAlrNYkzAVksjd3DNG9h3J2BK6zzFgugVE0
 UnDPOTYRVywrVRh5nUnzYFhcQemMZdddJgr0IdrSVEL+KN/vkIgWRrpuWG01Nd2oAAew=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> The kfree() function was called in two cases by the mac_ioctl() function
>> during error handling even if the passed variable did not contain a pointer
>> for a valid data item.
>>
>> * This implementation detail could be improved by the introduction
>>   of another jump label.
>>
>> * Drop an unnecessary initialisation for the variable "buff" then.
> 
> That's a different issue, please fix it in a separate patch.

I have got an other opinion here.
This update suggestion depends on a small source code clean-up
from the previous patch, doesn't it?

Do you want that I split the second suggestion from this series
into more steps?

Regards,
Markus