From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934057AbbGHRsZ (ORCPT ); Wed, 8 Jul 2015 13:48:25 -0400 Received: from mout.web.de ([212.227.15.4]:55691 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758785AbbGHRsW (ORCPT ); Wed, 8 Jul 2015 13:48:22 -0400 Subject: Re: [PATCH] bcache: Deletion of an unnecessary check before the function call "kobject_put" To: Kent Overstreet , Neil Brown , linux-bcache@vger.kernel.org References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546CFECC.8020309@users.sourceforge.net> Cc: linux-raid@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <559D625D.2020408@users.sourceforge.net> Date: Wed, 8 Jul 2015 19:48:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <546CFECC.8020309@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:dQKyBw8iKkb+yr9AailkcqI6e1jKS4nV0N2I6mEJtMJIInIDRre CIOxVhyOFfwmIWHp6Z3ZetSbO83As5DJlzTMR8y/WkxCy8wniF0ykeZ/K5dzVdsit0WZ1zz I1L8g4Xal5ktnLMn0f3Hx/tZmqSeQXHpZ4hG+0UGtGJEmXa1tW2bnaTy4uQ3T51ZQtiBW+j fn1yTgGiRac9nknDq9/Iw== X-UI-Out-Filterresults: notjunk:1;V01:K0:09R62HhU9x4=:vSEB2CGlOYgCygaXhpdUYe sZgAgdMXQWQfxT1FsxW7n7JYuH9mJNdMNrxRUQh5gD1qEAFEwX065oIyFLy/2zecqbNLQ7xnV XEOVxookpaEJOBTstMwswLo+mRBuDbT2w4dpuo6LD+RIjXG35QDzdhhkLcjloc186niwQXjze IcEFTbnV9raSoV+nKvtXdB29K32Xmnkv00UhulooXUJIpdzSFxhgpTIjXdjjgkocPizdsHkQR /gIhKj10w+Q9JhImy113Ok17PfI5KJ8NQys23+SgeM5zsfy5gEP+n8PWbxQbqJDz0QZsD20y+ 7KYCQsinw0PrMdbIchVyA/3LKFqf+J5A23ujKdX4yLZOIR8VHk73I/Mi4fyBBd1btv5PkS8rB njt7amtCcSrGwwXe1CAXybxmKB8rYTtdUa2ZlIWvAVRixgqYTPFHCSC1rm0DY/x9Ow9pM/jnC lsv2H3NFkqGyUptjkBIkR7NdgVnXNFDmChaXEmJSPrD8ddWV5/z04QftluWUhYLF3aLVwDNRa v+IAj/4ob9l5Z8uySH538TavhrdGxiLwSH2+Zzftbr8tcZ+sCyj4Dhue165Jizqa7I13CasDl KmBGab8iAGNwQaEoFBrmszxVCtlTtL5yJU2+o45HJ4DhyAdb5Um4UzQG5WmwTEDp4uu5wJ8fU FicjuDNIF7lda6zwnawuFo4IMtmSjkkWkm1O8Nan4ykqvbZEtJsYYVBDS8NKSl3U+3k4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Markus Elfring > Date: Wed, 19 Nov 2014 21:25:39 +0100 > > The kobject_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/md/bcache/super.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index d4713d0..1443c55 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -2076,8 +2076,7 @@ static void bcache_exit(void) > { > bch_debug_exit(); > bch_request_exit(); > - if (bcache_kobj) > - kobject_put(bcache_kobj); > + kobject_put(bcache_kobj); > if (bcache_wq) > destroy_workqueue(bcache_wq); > if (bcache_major) > Would you like to integrate this update suggestion into another source code repository? Regards, Markus