From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758807AbbGHSka (ORCPT <rfc822;w@1wt.eu>);
	Wed, 8 Jul 2015 14:40:30 -0400
Received: from mout.web.de ([212.227.15.4]:63289 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754825AbbGHSk2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 8 Jul 2015 14:40:28 -0400
Subject: Re: [PATCH] GPU-DRM-Tegra: Delete an unnecessary check before the
 function call "vunmap"
To: Alexandre Courbot <gnurou@gmail.com>, David Airlie <airlied@linux.ie>,
        Stephen Warren <swarren@wwwdotorg.org>,
        =?UTF-8?Q?Terje_Bergstr=c3=b6m?= <tbergstrom@nvidia.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org
References: <5307CAA2.8060406@users.sourceforge.net>
 <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
 <530A086E.8010901@users.sourceforge.net>
 <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
 <530A72AA.3000601@users.sourceforge.net>
 <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
 <530B5FB6.6010207@users.sourceforge.net>
 <alpine.DEB.2.10.1402241710370.2074@hadrien>
 <530C5E18.1020800@users.sourceforge.net>
 <alpine.DEB.2.10.1402251014170.2080@hadrien>
 <530CD2C4.4050903@users.sourceforge.net>
 <alpine.DEB.2.10.1402251840450.7035@hadrien>
 <530CF8FF.8080600@users.sourceforge.net>
 <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
 <530DD06F.4090703@users.sourceforge.net>
 <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
 <5317A59D.4@users.sourceforge.net> <54D335FA.6020101@users.sourceforge.net>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <559D6E90.1040005@users.sourceforge.net>
Date: Wed, 8 Jul 2015 20:40:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.0.1
MIME-Version: 1.0
In-Reply-To: <54D335FA.6020101@users.sourceforge.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:TIzneQNWDnDl7xmk1ER6l/x5XJj3pn7B2C2nfmPJ2YS+RWJDUHJ
 tUfx2sEYWYxWxKLl0Anqi0cCT6WdE8cO3jE9Jj7Y7Rvrf+prPeBjXF7Swv3LouED6+kvxzK
 R4yUw4Cfi32Fycxa6EecnJMlk2UjLFEcdDccvYAJ6Vlj7CYnG9GYlg63xr7Egbs1SRMUYa6
 yiBlqkb6gIj0SuxXnRaEA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:UilCYnJbu88=:6RcFlGclUxwk/M4kmvCs8O
 LK5QcS1pHyuvRjKs9hNdHRgxlDQFZshbEpCw0SMxBVpnd5mMHHTm2DH5F4IoibKMjxIj+/Gkd
 Yp4tUu0JSo2NldmcjzIctZ9On6efW1pCI86H5XikyM/4HsDGyMEhP1vcjx15WVGLqPf+YAaYb
 xANQWyUvAZIp+oMQLv0UepnQsr/0OPjxYQ798DgnAhpp0g0eD7ZLPMllDj8hoAwzwSjbDAmmo
 ly3ZyOVSXG8Ov79Ur8/1khRdJBQcg+vxLC+y3q1jfXekd0mDR4cn0FhdnWl4J+r0d2zonJRG8
 fcXSumnqDsdlppAlvwMh9+/KOhxOII7xZk/gCAPR/eWnChuRq9iG7Z9da3gNDBA5SXfoE6xzG
 xyuxRpLw+QsmLBkqVvLVYOrAfu3TZSWpIBwQOjPJrKXfL0X2MmejIrZ/qVunOWtv/7JX5RJJy
 FpF1pkNKEhwiRzQRzVGM3yVS/zUU5ZH6U7N0BIIZnQ6QJS4Mr4xEcjkOzTPc1FNib87Ki6SBL
 6Q4TuVPaUDTjGjInQdygXlBy3xn2MsnA4515x34jZgZu0ALfOu2WEUTP9WOwtEvY/79lZTph3
 VSeSggebwiP8Jnc6nQCSYtP5tqOrLJQ2+kyAJ6G2AOk7zcAmagUTlILV2W5P9ZQisoQ0H3zl4
 nT8NglvE1+sjLhC6K68rMOYWc3I0Q2XsKBwUP1yMHftvphHduz1/+4zLFwOU4YyA06Aw=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 5 Feb 2015 10:12:51 +0100
> 
> The vunmap() function performs also input parameter validation.
> Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/gpu/drm/tegra/fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
> index e9c715d..803598e 100644
> --- a/drivers/gpu/drm/tegra/fb.c
> +++ b/drivers/gpu/drm/tegra/fb.c
> @@ -66,7 +66,7 @@ static void tegra_fb_destroy(struct drm_framebuffer *framebuffer)
>  		struct tegra_bo *bo = fb->planes[i];
>  
>  		if (bo) {
> -			if (bo->pages && bo->vaddr)
> +			if (bo->pages)
>  				vunmap(bo->vaddr);
>  
>  			drm_gem_object_unreference_unlocked(&bo->gem);
> 

Would you like to integrate this update suggestion
into another source code repository?

Regards,
Markus