From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752380AbbGIG6k (ORCPT ); Thu, 9 Jul 2015 02:58:40 -0400 Received: from mout.web.de ([212.227.17.11]:54046 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752119AbbGIG6a (ORCPT ); Thu, 9 Jul 2015 02:58:30 -0400 Subject: Re: [PATCH] IOMMU-Tegra: gart: Delete an unnecessary check before the function call "vfree" To: Alexandre Courbot , Hiroshi Doyu , =?UTF-8?B?SsO2cmcgUsO2ZGVs?= , Stephen Warren , Thierry Reding , iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54D3A1A9.9040709@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <559E1B88.5030005@users.sourceforge.net> Date: Fri, 9 Jan 2015 07:58:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <54D3A1A9.9040709@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:mt/UfVSv71px+etU9nqxyUXuIpriVt8UoqeDJysUAkiOakSJCAC GcZXA1gUkUv6KRV6c5oo5QXXloLpXZS3DMATm/v89+E/2gbkpUchcIlwgtHMIrW5ThCGNui hvOQSea93oBLzbxq7GR6S9cdGr6S5GgbCV0SzEUo6o5OoWTH7Rhz+SFf4MKTC5/i3Bdjyxt XwsxpgxnzcCJdbzguQ5XA== X-UI-Out-Filterresults: notjunk:1;V01:K0:ul0nfvmjnA8=:hL8iBWVZmIJu/lrbq8QAkG z1sMgdvZcwPHJWtT3GFecdLvwXAen3CNoeE3kh+8Sg2ufad5eTq+CSg1WCcupr7agC0Kkz2c4 7USgqplJLLVhHUYpUEvrQB5sI+qlVplTKQKXSufloRPrY6iEMahvZVfjDTyVxUy6tUKrSRDq0 IlXdKL2b3173jSpevqj6RcZXDru/USYdxPWnrIm/062GBGOZxumceVbL/RD96h12JMphIfhXu K8yEkKBzxiS6FNi62rvMdH1w85Rt1hVN1cH+ePU2pRJ0ElX99t2I21D4TSjmcPCF4K9wNjDVu gHGrmKPTAZWz5xpPLcZlMX2NW6Cgt/czoG7nxypkopfo1dY86Uq0O7x/a6IjLuYwaTZmwyY3U jLvDnYtJ88AIsYTvSUPwtV2SmJm7JSdnKPr8rjLtbxjLSwS6N5Aqu9wVvI0P3Z5/yG9h80kD5 kJccvOoj2gecjH+p0K8Ob46XSkPOknDQypwehfsP7bo9lu8SZXZm9yngFAy8H8/lqRe6vIYHk Wor4/X1N3LS1ItDeQqA6Kw2aBaUr9bMSYtKR6GTUCh/pEgsDZAo9NMHN0V7rwdHQQZmOSDYwM Rk7F3g+NJK77Y8Cx+HwQh+k38we4G8BgISxeoS1XGxe2553yMhyDCFs5HvM5eSiIuCxX6IMDT QwCkA2umXgLFzL2uj06tMnlmzQrlwQY2+FkOkNfWGgtK/lP2weAB0eIBKW+vHEh5rcqw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Markus Elfring > Date: Thu, 5 Feb 2015 17:54:16 +0100 > > The vfree() function performs also input parameter validation. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/iommu/tegra-gart.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c > index f722a0c..07a795a 100644 > --- a/drivers/iommu/tegra-gart.c > +++ b/drivers/iommu/tegra-gart.c > @@ -404,8 +404,7 @@ static int tegra_gart_remove(struct platform_device *pdev) > struct gart_device *gart = platform_get_drvdata(pdev); > > writel(0, gart->regs + GART_CONFIG); > - if (gart->savedata) > - vfree(gart->savedata); > + vfree(gart->savedata); > gart_handle = NULL; > return 0; > } > Would you like to integrate this update suggestion into another source code repository? Regards, Markus