From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752647AbbGIIXZ (ORCPT ); Thu, 9 Jul 2015 04:23:25 -0400 Received: from mout.web.de ([212.227.17.12]:52792 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751727AbbGIIW7 (ORCPT ); Thu, 9 Jul 2015 04:22:59 -0400 Subject: Re: [PATCH] SCSI-aic7...: Delete unnecessary checks before the function call "kfree" To: Hannes Reinecke , "James E. J. Bottomley" , linux-scsi@vger.kernel.org References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54D3E057.9030600@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <559E2F54.9030905@users.sourceforge.net> Date: Thu, 9 Jul 2015 10:22:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <54D3E057.9030600@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:IFW8zIcN77SDeqlFieOe3e7W61CDIW7B07o8masSsqVg9xqL1PU toAy2pOGCrXAqzZvErAwCGlSMh5hGT/NXIjbstbB5ALmmyeXDmXf1I7jjOBHdpIFuxW/u5u U9X9VXriCuZEvsFeOObIvgdX93pQQ6l9Dt51IWuNDYtoYHy/3uUPICfmduZdNXg2jrCx+wn RS14bOinbTJDVVPzZkdyg== X-UI-Out-Filterresults: notjunk:1;V01:K0:jFlg/CL7w6A=:gETRpzQKHFunNQE8A7Ty/I liWX+9RJVu4vDfiR2t/gC+JC+YNHJfMoqa1+y+moEwy1BOvD0d5Vf5rRvAXhMlGyMB+s72zdb EGMqZCJ2g+1ThpWXQZ8O5sE/zedGOQINPy0Pg3/Are4YCfGy9IWhGsROMuWEmr2oyAiW+WzwQ PlEJN01+JcShNYhv4rvzTVsIZqIt8bsnWdec2hUonxJ6/VqscQxqvODxaGmBSuKuApPLjLGC/ 1tlKs+SIm05UySna88ZhaNIopHZioR4kZv1gvV9Cp1SSxLJOtyYuIB+3JKJytYShfkMOVwj/7 lAyrXarhUCVt0TQNwumiwFb2xiUkO9TanK+LP7LDPlkgnIBuTixpEvC4UYwZ8AjJXC9mSsshL tb2my8POby/F+FRstHKQhjAlNYtXiET11F11KKLsDjEUkQE3UhQereFgTbz6YFnUs+HPoj74a iUpMKTfOPYxlWU3xjnDguS4mnyOQ7pRfOvy/MQBnhBt8Z67MI1+l20BfEdGEoa1Dbzo6XZ5WK 3gNFcdEISASfTIqdrLIhEaPpzz32IiJDAAL1cjoHqk/wjFseYka0sGG6h+ddtozw4BXyeideC PCmajFQunEQUGaNyCK709M923Cfxl30vgC/MaK+Vg/d522lCsjjZ07Rhc4o/INcZ6Z3DL70DR GdDYKWk0Ush+8lnchB6QZwNG9uvWiNsnFiqa06oOGPc69oxXoGzKKNp+Ayglk0EcFEl0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 05.02.2015 um 22:27 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Thu, 5 Feb 2015 22:23:48 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/scsi/aic7xxx/aic7xxx_core.c | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-) > > diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c > index 10172a3..98a5ed1 100644 > --- a/drivers/scsi/aic7xxx/aic7xxx_core.c > +++ b/drivers/scsi/aic7xxx/aic7xxx_core.c > @@ -2200,8 +2200,7 @@ ahc_free_tstate(struct ahc_softc *ahc, u_int scsi_id, char channel, int force) > if (channel == 'B') > scsi_id += 8; > tstate = ahc->enabled_targets[scsi_id]; > - if (tstate != NULL) > - kfree(tstate); > + kfree(tstate); > ahc->enabled_targets[scsi_id] = NULL; > } > #endif > @@ -4482,8 +4481,7 @@ ahc_set_unit(struct ahc_softc *ahc, int unit) > void > ahc_set_name(struct ahc_softc *ahc, char *name) > { > - if (ahc->name != NULL) > - kfree(ahc->name); > + kfree(ahc->name); > ahc->name = name; > } > > @@ -4550,10 +4548,8 @@ ahc_free(struct ahc_softc *ahc) > kfree(ahc->black_hole); > } > #endif > - if (ahc->name != NULL) > - kfree(ahc->name); > - if (ahc->seep_config != NULL) > - kfree(ahc->seep_config); > + kfree(ahc->name); > + kfree(ahc->seep_config); > #ifndef __FreeBSD__ > kfree(ahc); > #endif > @@ -4958,8 +4954,7 @@ ahc_fini_scbdata(struct ahc_softc *ahc) > case 0: > break; > } > - if (scb_data->scbarray != NULL) > - kfree(scb_data->scbarray); > + kfree(scb_data->scbarray); > } > > static void > Would you like to integrate this update suggestion into another source code repository? Regards, Markus