From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752123AbbGIIfP (ORCPT ); Thu, 9 Jul 2015 04:35:15 -0400 Received: from mout.web.de ([212.227.17.12]:56417 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbbGIIfD (ORCPT ); Thu, 9 Jul 2015 04:35:03 -0400 Subject: Re: [PATCH] SCSI-libcxgbi: Deletion of an unnecessary check before the function call "dst_release" To: "James E. J. Bottomley" , linux-scsi@vger.kernel.org References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546EF5CC.1050308@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <559E322D.30705@users.sourceforge.net> Date: Thu, 9 Jul 2015 10:34:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <546EF5CC.1050308@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ayicSOxBiLhq75tMAb7lrA47iwEbSeFj7HPYne7FRIOHHU5JCYv JcLVlON1ftiw5dIIq2TCtGGC56mElHiszA39rTroXa6vZA9IejO9kjWM2ZR0Bdq7EbUd04J nj4DsS9/GfOi6DGB57o/8bDgJuDZitertpR0lylgTdtawAvl1s4FAL8uAHQ2Uz9MFy5g0Yr GGqq19csOupeLsoRSV/Og== X-UI-Out-Filterresults: notjunk:1;V01:K0:OaoBK9ITY0k=:ptKY9cM4odkeG3Ara1TEtN /knDP6aZw/XBtbIF7AUBSDRaW3Ek/ISVKHBMMEmdEyNnw5gBm6WaZ6XwGICNG8hg+vvtf2xXj KE3u3KeNL4sdcZO4LUnXbPI5ULnFNiRtTiDKCMHy/p08cHibZQ9XlmMLtLiGf2q/S+Sl50NAO tWLxhSNLdrJeMI8vtDO8kQrzbrsAN928FmhHnkm+POCDq7zuNO94WYVV5dJsimzdq8hg4HjpU DZXcY67+h7ZNF/TYYsscfhvmcnNrSosilXIPUtRs8twkHgt+mmI1QX8mDpRNXjzm1eyN4k53U gJZWvdw3Pj27IimX2JDVNo06LQXbpg4Sg7XSH1+4ZxgZP0upsuPPTyRU7bq9XzWkY3RalZgHF EpcqXS4/+4HndASeULDWYLvpCHJU8Cd2CgstAwDY+4kEfEpamwlgcWDag0/2AGxxHGC8TOC4a YOQCGGWEmVMPNvboVx/s3n91RmdZSuPhY3d2SKd89gKtyUnV7EK9NbmgO2uWlcXheoxqbGlrZ BBog+l7BDuzyftKVkWxjliN8VJ+OWWDa4CgJEq+QnnUGh9ymwgQQ17wyEtyLwZzMvCqnDicx5 Z57xS8yLyW0zZkJntMraihZ4ge23s85yoKSyEwYhl/CTvva6qjBUwd1lQ8dzEbDiZRks5mdOP GoBwwIf3gh+AdBgF6uRBhTFRDtuuFD9/ZDVpyE2dXZfksQrn9IK3Fd4eMzoCn1hl+52U= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Markus Elfring > Date: Fri, 21 Nov 2014 09:15:10 +0100 > > The dst_release() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/scsi/cxgbi/libcxgbi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c > index addd1dd..95d2654 100644 > --- a/drivers/scsi/cxgbi/libcxgbi.c > +++ b/drivers/scsi/cxgbi/libcxgbi.c > @@ -798,8 +798,7 @@ void cxgbi_sock_closed(struct cxgbi_sock *csk) > return; > if (csk->saddr.sin_port) > sock_put_port(csk); > - if (csk->dst) > - dst_release(csk->dst); > + dst_release(csk->dst); > csk->cdev->csk_release_offload_resources(csk); > cxgbi_sock_set_state(csk, CTP_CLOSED); > cxgbi_inform_iscsi_conn_closing(csk); > Would you like to integrate this update suggestion into another source code repository? Regards, Markus