From: Werner Sembach <wse@tuxedocomputers.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: airlied@linux.ie, daniel@ffwll.ch,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] Add missing check
Date: Wed, 5 May 2021 11:32:02 +0200 [thread overview]
Message-ID: <559ca7d0-f68d-32c8-d2d9-37f57d2ecdcd@tuxedocomputers.com> (raw)
In-Reply-To: <YJEW3J0+RQPo22AD@intel.com>
Am 04.05.21 um 11:41 schrieb Ville Syrjälä:
> On Mon, May 03, 2021 at 08:21:46PM +0200, Werner Sembach wrote:
>> Add a missing check that could potentially lead to an unarchivable mode being
>> validated.
>>
>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>> ---
>>
>> >From 54fa706f0a5f260a32af5d18b9622ceebb94c12e Mon Sep 17 00:00:00 2001
>> From: Werner Sembach <wse@tuxedocomputers.com>
>> Date: Mon, 3 May 2021 14:42:36 +0200
>> Subject: [PATCH 2/4] Add missing check
> I guess you did something a bit wonky with git format-patch/send-mail?
I have no idea how that timestamp happened, I will check when sending my next patch ^^.
>> ---
>> drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
>> index 576d3d910d06..ce165ef28e88 100644
>> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
>> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
>> @@ -1913,7 +1913,7 @@ intel_hdmi_mode_valid(struct drm_connector *connector,
>> clock *= 2;
>> }
>>
>> - if (drm_mode_is_420_only(&connector->display_info, mode))
>> + if (connector->ycbcr_420_allowed && drm_mode_is_420_only(&connector->display_info, mode))
> This one shouldn't be necessary. drm_mode_validate_ycbcr420() has
> already checked it for us.
I wasn't aware of drm_mode_validate_ycbcr420, thanks for the hint. In the "420_also"-patch I change drm_mode_is_420_only to drm_mode_is_420 (helper function: _only + _also), which is not checked by drm_mode_validate_ycbcr420. I can add this check to that patch, since its only required then.
>> clock /= 2;
>>
>> status = intel_hdmi_mode_clock_valid(hdmi, clock, has_hdmi_sink);
>> --
>> 2.25.1
next prev parent reply other threads:[~2021-05-05 9:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 18:21 [PATCH 0/4] drm/i915/display Try YCbCr420 color when RGB fails Werner Sembach
2021-05-03 18:21 ` [PATCH 1/4] New function to avoid duplicate code in upcomming commits Werner Sembach
2021-05-03 18:21 ` [PATCH 2/4] Add missing check Werner Sembach
2021-05-04 9:41 ` Ville Syrjälä
2021-05-05 9:32 ` Werner Sembach [this message]
2021-05-03 18:21 ` [PATCH 3/4] Restructure output format computation for better expandability Werner Sembach
2021-05-03 21:03 ` kernel test robot
2021-05-03 22:55 ` kernel test robot
2021-05-04 9:54 ` Ville Syrjälä
2021-05-05 9:54 ` Werner Sembach
2021-05-05 12:15 ` Ville Syrjälä
2021-05-05 13:02 ` Werner Sembach
2021-05-05 13:59 ` Ville Syrjälä
2021-05-03 18:21 ` [PATCH 4/4] Use YCbCr420 as fallback when RGB fails Werner Sembach
2021-05-04 10:08 ` Ville Syrjälä
2021-05-05 13:18 ` Werner Sembach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559ca7d0-f68d-32c8-d2d9-37f57d2ecdcd@tuxedocomputers.com \
--to=wse@tuxedocomputers.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).