From: Hanjun Guo <hanjun.guo@linaro.org>
To: Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, jason@lakedaemon.net
Cc: rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH] x86, acpi: Handle xapic/x2apic entries in MADT
Date: Mon, 13 Jul 2015 23:22:11 +0800 [thread overview]
Message-ID: <55A3D7A3.90609@linaro.org> (raw)
In-Reply-To: <1436795687-18539-1-git-send-email-lukasz.anaczkowski@intel.com>
Hi Lukasz,
On 07/13/2015 09:54 PM, Lukasz Anaczkowski wrote:
> This patch is based on work of "Yinghai Lu <yinghai@kernel.org>"
> previously published at https://lkml.org/lkml/2013/1/21/563.
>
> In case when BIOS is populating MADT wiht both x2apic and local apic
> entries (as per ACPI spec), kernel builds it's processor table
> in the following order: BSP, X2APIC, local APIC, resulting in
> processors on the same core are not separated by core count.
I'm confused here, I can't figure out where is the problem, could you
explain it in detail?
For me, logical CPU IDs allocated by OS will have mappings to physical
CPU IDs, what you are saying seems CPU topology problem to me.
>
> This patch fixes this behavior and resulting assignment is
> correct.
>
> Signed-off-by: Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
> ---
> arch/x86/kernel/acpi/boot.c | 29 +++++++++++++-----
> drivers/acpi/numa.c | 28 ++++++++++++-----
> drivers/acpi/tables.c | 75 ++++++++++++++++++++++++++++-----------------
> drivers/irqchip/irq-gic.c | 15 ++++++---
Anyway, You also miss the SMP boot for ARM64 in ACPI way, which will
cause compile error on ARM64.
Thanks
Hanjun
next prev parent reply other threads:[~2015-07-13 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 13:54 [PATCH] x86, acpi: Handle xapic/x2apic entries in MADT Lukasz Anaczkowski
2015-07-13 15:22 ` Hanjun Guo [this message]
2015-07-14 8:06 ` Lukasz Anaczkowski
2015-07-14 8:06 ` Lukasz Anaczkowski
2015-07-14 8:26 ` Jiang Liu
2015-07-14 11:17 ` Anaczkowski, Lukasz
2015-07-21 8:27 ` Thomas Gleixner
2015-07-14 14:24 ` Hanjun Guo
[not found] <alpine.DEB.2.11.1507211017590.18576 () nanos>
2015-07-30 17:43 ` Lukasz Anaczkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A3D7A3.90609@linaro.org \
--to=hanjun.guo@linaro.org \
--cc=hpa@zytor.com \
--cc=jason@lakedaemon.net \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.anaczkowski@intel.com \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).