From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752407AbbGOPYH (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Jul 2015 11:24:07 -0400
Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:61176 "EHLO
	eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751546AbbGOPYF convert rfc822-to-8bit
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Jul 2015 11:24:05 -0400
Message-ID: <55A67B0D.9030804@arm.com>
Date: Wed, 15 Jul 2015 16:23:57 +0100
From: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Hugh Dickins <hughd@google.com>
CC: Dave Hansen <dave.hansen@intel.com>, Mel Gorman <mgorman@suse.de>,
        Rik van Riel <riel@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
        Christoph Lameter <cl@gentwo.org>,
        Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
        Steve Capper <steve.capper@linaro.org>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
        Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko <mhocko@suse.cz>,
        Jerome Marchand <jmarchan@redhat.com>,
        Sasha Levin <sasha.levin@oracle.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 17/36] arm64, thp: remove infrastructure for handling
 splitting PMDs
References: <1436550130-112636-1-git-send-email-kirill.shutemov@linux.intel.com> <1436550130-112636-18-git-send-email-kirill.shutemov@linux.intel.com>
In-Reply-To: <1436550130-112636-18-git-send-email-kirill.shutemov@linux.intel.com>
X-OriginalArrivalTime: 15 Jul 2015 15:23:57.0528 (UTC) FILETIME=[449E3580:01D0BF12]
X-MC-Unique: ze6Gn6SMTuK5VodBLcP2dA-1
Content-Type: text/plain; charset=WINDOWS-1252; format=flowed
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/07/15 18:41, Kirill A. Shutemov wrote:
> With new refcounting we don't need to mark PMDs splitting. Let's drop
> code to handle this.
>
> pmdp_splitting_flush() is not needed too: on splitting PMD we will do
> pmdp_clear_flush() + set_pte_at(). pmdp_clear_flush() will do IPI as
> needed for fast_gup.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
>   arch/arm64/include/asm/pgtable.h |  9 ---------
>   arch/arm64/mm/flush.c            | 16 ----------------
>   2 files changed, 25 deletions(-)
>
> diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h
> index bd5db28324ba..37cdbf37934c 100644
> --- a/arch/arm64/include/asm/pgtable.h
> +++ b/arch/arm64/include/asm/pgtable.h
> @@ -274,20 +274,11 @@ static inline pgprot_t mk_sect_prot(pgprot_t prot)
>
>   #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>   #define pmd_trans_huge(pmd)	(pmd_val(pmd) && !(pmd_val(pmd) & PMD_TABLE_BIT))
> -#define pmd_trans_splitting(pmd)	pte_special(pmd_pte(pmd))
> -#ifdef CONFIG_HAVE_RCU_TABLE_FREE
> -#define __HAVE_ARCH_PMDP_SPLITTING_FLUSH
> -struct vm_area_struct;
> -void pmdp_splitting_flush(struct vm_area_struct *vma, unsigned long address,
> -			  pmd_t *pmdp);
> -#endif /* CONFIG_HAVE_RCU_TABLE_FREE */
> -#endif /* CONFIG_TRANSPARENT_HUGEPAGE */

Wouldn't this cause a build failure(Untested) ? We need to retain the last line,

#endif /* CONFIG_TRANSPARENT_HUGEPAGE */

isn't it ?


Thanks
Suzuki