From: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, robh+dt@kernel.org,
yizhang@marvell.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH-v4 00/11] i2c: pxa: Fixes, cleanup and support for pxa910 family
Date: Mon, 20 Jul 2015 12:42:33 +0530 [thread overview]
Message-ID: <55AC9F61.3090207@linaro.org> (raw)
In-Reply-To: <55AC9E8E.8080708@linaro.org>
On Monday 20 July 2015 12:39 PM, Vaibhav Hiremath wrote:
>
>
> On Monday 20 July 2015 12:36 PM, Vaibhav Hiremath wrote:
>>
>>
>> On Saturday 18 July 2015 01:19 AM, Robert Jarzmik wrote:
>>> Vaibhav Hiremath <vaibhav.hiremath@linaro.org> writes:
>>>
>>>>> So, I applied patches 1-6 to for-next to make some progress.
>>>>>
>>>>> The others need more thought because of the bindings which shall be
>>>>> discussed replying to the patches in question.
>>>>>
>>>>> Thanks for the updated work with lots of proper references.
>>>>>
>>>>
>>>> OK, Thanks and no issues.
>>>>
>>>> Lets discuss more on the bindings.
>>>
>>> I made a simple try on my reference platform with the whole patchset.
>>> It oopses on a NULL dereference.
>>>
>>> The stack is in [1].
>>> I think it boils down to :
>>> - i2c_pxa_do_sclk_adj()
>>> - reg_ilcr = readl(_ILCR(i2c));
>>>
>>> I also think the faulty patch is :
>>> - i2c: pxa: Add ILCR (tLow & tHigh) configuration support
>>>
>>> My case, an I2C master case, I'd like you to find the issue and fix it.
>>>
>>
>> Which is this reference platform?
>> Can you share few details -
>>
>> - reference Platform?
>> - DT file if you could
>> - Boot log (if you could)
>>
>>
>> I am using pxa1928 based platform, and I do not see any issues.
>>
>
> Having said that,
> I see issues in the patch for non PXA910 platform, where
> i2c_pxa_do_sclk_adj() will be called unconditionally and obviously
> reg_ilcr and reg_wcr are not set.
>
> I will fix this and send the patch.
>
This should fix the issue -
hvaibhav@hvaibhav-ThinkPad-T440p:~/projects/mainline/linux$ git diff
drivers/i2c/busses/i2c-pxa.c
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index e0aa087..9e372fc 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -590,6 +590,9 @@ static void i2c_pxa_do_sclk_adj(struct pxa_i2c *i2c)
{
unsigned int reg_ilcr;
+ if (!i2c->reg_ilcr)
+ return;
+
reg_ilcr = readl(_ILCR(i2c));
/* For standard/fast mode tlow and thigh counters are same */
If you are ok, I will re-spin the patch and submit.
Thanks,
Vaibhav
next prev parent reply other threads:[~2015-07-20 7:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 7:36 [PATCH-v4 00/11] i2c: pxa: Fixes, cleanup and support for pxa910 family Vaibhav Hiremath
2015-07-14 7:36 ` [PATCH-v4 01/11] i2c: pxa: keep i2c irq ON in suspend Vaibhav Hiremath
2015-07-14 7:36 ` [PATCH-v4 02/11] i2c: pxa: No need to set slave addr for i2c master mode reset Vaibhav Hiremath
2015-07-14 7:36 ` [PATCH-v4 03/11] i2c: pxa: Return I2C_RETRY when timeout in pio mode Vaibhav Hiremath
2015-07-14 7:36 ` [PATCH-v4 04/11] i2c: pxa: Fix compile warning in 64bit mode Vaibhav Hiremath
2015-07-14 7:36 ` [PATCH-v4 05/11] i2c: pxa: Update debug function to dump more info on error Vaibhav Hiremath
2015-07-14 7:36 ` [PATCH-v4 06/11] i2c:pxa: Use devm_ variants in probe function Vaibhav Hiremath
2015-07-14 11:35 ` Wolfram Sang
2015-07-14 11:39 ` Vaibhav Hiremath
2015-07-14 11:45 ` Wolfram Sang
2015-07-14 7:36 ` [PATCH-v4 07/11] i2c: pxa: enable/disable i2c module across msg xfer Vaibhav Hiremath
2015-07-14 7:36 ` [PATCH-v4 08/11] Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa Vaibhav Hiremath
2015-07-14 7:36 ` [PATCH-v4 09/11] i2c: pxa: Add support for pxa910/988 & new configuration features Vaibhav Hiremath
2015-07-14 7:36 ` [PATCH-v4 10/11] i2c: pxa: Add ILCR (tLow & tHigh) configuration support Vaibhav Hiremath
2015-07-14 7:36 ` [PATCH-v4 11/11] Documentation: binding: add sclk adjustment properties to i2c-pxa Vaibhav Hiremath
2015-07-14 11:34 ` [PATCH-v4 00/11] i2c: pxa: Fixes, cleanup and support for pxa910 family Wolfram Sang
2015-07-14 11:36 ` Vaibhav Hiremath
2015-07-17 19:49 ` Robert Jarzmik
2015-07-20 7:06 ` Vaibhav Hiremath
2015-07-20 7:09 ` Vaibhav Hiremath
2015-07-20 7:12 ` Vaibhav Hiremath [this message]
2015-07-20 20:30 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AC9F61.3090207@linaro.org \
--to=vaibhav.hiremath@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
--cc=yizhang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).