From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752568AbbG0LLN (ORCPT ); Mon, 27 Jul 2015 07:11:13 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:34932 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280AbbG0LLK (ORCPT ); Mon, 27 Jul 2015 07:11:10 -0400 Message-ID: <55B611B9.9030708@gmail.com> Date: Mon, 27 Jul 2015 13:10:49 +0200 From: "Michael Kerrisk (man-pages)" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pavel Machek , Peter Zijlstra CC: mtk.manpages@gmail.com, Thomas Gleixner , Darren Hart , "Carlos O'Donell" , Ingo Molnar , Jakub Jelinek , "linux-man@vger.kernel.org" , lkml , Davidlohr Bueso , Arnd Bergmann , Steven Rostedt , Linux API , Torvald Riegel , Roland McGrath , Darren Hart , Anton Blanchard , Eric Dumazet , bill o gallmeister , Jan Kiszka , Daniel Wagner , Rich Felker , Andy Lutomirski , bert hubert , Rusty Russell , Heinrich Schuchardt Subject: Re: Revised futex(2) man page for review References: <55166C01.7000803@gmail.com> <20150328114725.GJ27490@worktop.programming.kicks-ass.net> <20150427203705.GE29351@xo-6d-61-c0.localdomain> In-Reply-To: <20150427203705.GE29351@xo-6d-61-c0.localdomain> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Pavel, On 04/27/2015 10:37 PM, Pavel Machek wrote: > Hi! > >> The FUTEX_WAIT_OP operation is equivalent to execute the follow??? >> ing code atomically and totally ordered with respect to other >> futex operations on any of the two supplied futex words: > > "to executing"? Yep. Fixed. >> The operation and comparison that are to be performed are >> encoded in the bits of the argument val3. Pictorially, the >> encoding is: >> >> +---+---+-----------+-----------+ >> |op |cmp| oparg | cmparg | >> +---+---+-----------+-----------+ >> 4 4 12 12 <== # of bits >> > > :-) > >> RETURN VALUE >> In the event of an error, all operations return -1 and set errno to >> indicate the cause of the error. The return value on success depends >> on the operation, as described in the following list: > > Did you say (at the begining) that there is no glibc wrapper? Yes, this could be clearer. I changed it to RETURN VALUE In the event of an error (and assuming that futex() was invoked via syscall(2)), all operations return -1 and set errno to indi‐ cate the cause of the error. >> EINVAL The operation in futex_op is one of those that employs a time??? >> out, but the supplied timeout argument was invalid (tv_sec was >> less than zero, or tv_nsec was not less than 1000,000,000). > > 1,000...? Fixed. Thanks for the comments! Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/