From: Jaehoon Chung <jh80.chung@samsung.com>
To: Shawn Lin <shawn.lin@rock-chips.com>, ulf.hansson@linaro.org
Cc: heiko@sntech.de, dianders@chromium.org,
Vineet.Gupta1@synopsys.com, Wei Xu <xuwei5@hisilicon.com>,
Joachim Eastwood <manabian@gmail.com>,
Alexey Brodkin <abrodkin@synopsys.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Jun Nie <jun.nie@linaro.org>, Ralf Baechle <ralf@linux-mips.org>,
Govindraj Raja <govindraj.raja@imgtec.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-mips@linux-mips.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
CPGS <cpgs@samsung.com>
Subject: Re: [RFC PATCH v4 0/9]
Date: Thu, 06 Aug 2015 16:33:42 +0900 [thread overview]
Message-ID: <55C30DD6.8020802@samsung.com> (raw)
In-Reply-To: <55C30D52.6040802@rock-chips.com>
On 08/06/2015 04:31 PM, Shawn Lin wrote:
> 在 2015/8/6 15:08, Jaehoon Chung 写道:
>> Hi, Shawn.
>>
>> I remembered that Krzysztof has mentioned "Fix the title of cover letter."
>> Your cover letter's title is nothing.. "[RFC PATCH v4 0/9] " ??
>> [RFC PATCH v4 0/9] your title...
> Sorry, I forgot it, and will fix in next version...
No problem :)
At next time, add the title at your cover-letter, plz.
Best Regards,
Jaehoon Chung
>
>> Best Regards,
>> Jaehoon Chung
>>
>> On 08/06/2015 03:44 PM, Shawn Lin wrote:
>>> Add external dma support for Synopsys MSHC
>>>
>>> Synopsys DesignWare mobile storage host controller supports three
>>> types of transfer mode: pio, internal dma and external dma. However,
>>> dw_mmc can only supports pio and internal dma now. Thus some platforms
>>> using dw-mshc integrated with generic dma can't work in dma mode. So we
>>> submit this patch to achieve it.
>>>
>>> And the config option, CONFIG_MMC_DW_IDMAC, was added by Will Newton
>>> (commit:f95f3850) for the first version of dw_mmc and never be touched since
>>> then. At that time dt-bindings hadn't been introduced into dw_mmc yet means
>>> we should select CONFIG_MMC_DW_IDMAC to enable internal dma mode at compile
>>> time. Nowadays, device-tree helps us to support a variety of boards with one
>>> kernel. That's why we need to remove it and decide the transfer mode by reading
>>> dw_mmc's HCON reg at runtime.
>>>
>>> This RFC patch needs lots of ACKs. I know it's hard, but it does need someone
>>> to make the running.
>>>
>>> Patch does the following things:
>>> - remove CONFIG_MMC_DW_IDMAC config option
>>> - add bindings for edmac used by synopsys-dw-mshc
>>> at runtime
>>> - add edmac support for synopsys-dw-mshc
>>>
>>> Patch is based on next of git://git.linaro.org/people/ulf.hansson/mmc
>>>
>>>
>>> Changes in v4:
>>> - remove "host->trans_mode" and use "host->use_dma" to indicate
>>> transfer mode.
>>> - remove all bt-bindings' changes since we don't need new properities.
>>> - check transfer mode at runtime by reading HCON reg
>>> - spilt defconfig changes for each sub-architecture
>>> - fix the title of cover letter
>>> - reuse some code for reducing code size
>>>
>>> Changes in v3:
>>> - choose transfer mode at runtime
>>> - remove all CONFIG_MMC_DW_IDMAC config option
>>> - add supports-idmac property for some platforms
>>>
>>> Changes in v2:
>>> - Fix typo of dev_info msg
>>> - remove unused dmach from declaration of dw_mci_dma_slave
>>>
>>> Shawn Lin (9):
>>> mmc: dw_mmc: Add external dma interface support
>>> Documentation: synopsys-dw-mshc: add bindings for idmac and edmac
>>> mips: pistachio_defconfig: remove CONFIG_MMC_DW_IDMAC
>>> arc: axs10x_defconfig: remove CONFIG_MMC_DW_IDMAC
>>> arm: exynos_defconfig: remove CONFIG_MMC_DW_IDMAC
>>> arm: hisi_defconfig: remove CONFIG_MMC_DW_IDMAC
>>> arm: lpc18xx_defconfig: remove CONFIG_MMC_DW_IDMAC
>>> arm: multi_v7_defconfig: remove CONFIG_MMC_DW_IDMAC
>>> arm: zx_defconfig: remove CONFIG_MMC_DW_IDMAC
>>>
>>> .../devicetree/bindings/mmc/synopsys-dw-mshc.txt | 25 ++
>>> arch/arc/configs/axs101_defconfig | 1 -
>>> arch/arc/configs/axs103_defconfig | 1 -
>>> arch/arc/configs/axs103_smp_defconfig | 1 -
>>> arch/arm/configs/exynos_defconfig | 1 -
>>> arch/arm/configs/hisi_defconfig | 1 -
>>> arch/arm/configs/lpc18xx_defconfig | 1 -
>>> arch/arm/configs/multi_v7_defconfig | 1 -
>>> arch/arm/configs/zx_defconfig | 1 -
>>> arch/mips/configs/pistachio_defconfig | 1 -
>>> drivers/mmc/host/Kconfig | 11 +-
>>> drivers/mmc/host/dw_mmc-pltfm.c | 2 +
>>> drivers/mmc/host/dw_mmc.c | 258 +++++++++++++++++----
>>> include/linux/mmc/dw_mmc.h | 27 ++-
>>> 14 files changed, 257 insertions(+), 75 deletions(-)
>>>
>>
>>
>>
>
>
prev parent reply other threads:[~2015-08-06 7:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 6:44 [RFC PATCH v4 0/9] Shawn Lin
2015-08-06 6:44 ` [RFC PATCH v4 1/9] mmc: dw_mmc: Add external dma interface support Shawn Lin
2015-08-06 7:08 ` Krzysztof Kozlowski
2015-08-06 7:26 ` Shawn Lin
2015-08-06 7:37 ` Krzysztof Kozlowski
2015-08-07 21:32 ` Joachim Eastwood
2015-08-07 23:37 ` Shawn Lin
2015-08-10 18:03 ` Alim Akhtar
2015-08-10 23:35 ` Shawn Lin
2015-08-06 6:45 ` [RFC PATCH v4 2/9] Documentation: synopsys-dw-mshc: add bindings for idmac and edmac Shawn Lin
2015-08-06 6:45 ` [RFC PATCH v4 3/9] mips: pistachio_defconfig: remove CONFIG_MMC_DW_IDMAC Shawn Lin
2015-08-06 9:05 ` Govindraj Raja
2015-08-06 13:17 ` Ralf Baechle
2015-08-12 22:05 ` Ralf Baechle
2015-08-13 0:08 ` Shawn Lin
2015-08-06 6:45 ` [RFC PATCH v4 4/9] arc: axs10x_defconfig: " Shawn Lin
2015-08-07 5:48 ` Vineet Gupta
2015-08-06 6:45 ` [RFC PATCH v4 5/9] arm: exynos_defconfig: " Shawn Lin
2015-08-06 7:08 ` Krzysztof Kozlowski
2015-08-06 6:45 ` [RFC PATCH v4 6/9] arm: hisi_defconfig: " Shawn Lin
2015-08-13 10:18 ` Wei Xu
2015-08-06 6:46 ` [RFC PATCH v4 7/9] arm: lpc18xx_defconfig: " Shawn Lin
2015-08-07 21:34 ` Joachim Eastwood
2015-08-06 6:46 ` [RFC PATCH v4 8/9] arm: multi_v7_defconfig: " Shawn Lin
2015-08-06 6:46 ` [RFC PATCH v4 9/9] arm: zx_defconfig: " Shawn Lin
2015-08-06 7:08 ` [RFC PATCH v4 0/9] Jaehoon Chung
2015-08-06 7:31 ` Shawn Lin
2015-08-06 7:33 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C30DD6.8020802@samsung.com \
--to=jh80.chung@samsung.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=abrodkin@synopsys.com \
--cc=cpgs@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=govindraj.raja@imgtec.com \
--cc=heiko@sntech.de \
--cc=jun.nie@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=manabian@gmail.com \
--cc=ralf@linux-mips.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).