From: Vladimir Zapolskiy <vz@mleia.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Jean Delvare <jdelvare@suse.com>,
Ian Munsie <imunsie@au1.ibm.com>,
Michael Neuling <mikey@neuling.org>,
Arnd Bergmann <arnd@arndb.de>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] misc: remove boundary checks from bin attr users
Date: Fri, 07 Aug 2015 19:15:46 +0300 [thread overview]
Message-ID: <55C4D9B2.3000708@mleia.com> (raw)
In-Reply-To: <20150807161055.GD25357@katana>
Hi Wolfram,
On 07.08.2015 19:10, Wolfram Sang wrote:
> Vladimir,
>
> On Mon, Jul 27, 2015 at 12:18:22AM +0300, Vladimir Zapolskiy wrote:
>> This change removes a number of redundant checks on bin attribute
>> client's side, the same checks are done by sysfs_kf_bin_read() or
>> sysfs_kf_bin_write() caller from fs/sysfs/file.c.
>>
>> Note, drivers/misc/pch_phub.c and drivers/misc/c2port/core.c may be
>> updated in a similar way, however this task is not done due to more
>> complicated read()/write() callbacks.
>
> Can you resend the patches which touch i2c drivers with me on cc? I'd
> like to take care of them.
if we're talking about this particular series, you should have them in
your mailbox, since you have them applied in wsa/i2c/for-next:
commit d12c0aaf3780c5b26b4ea9e795252381f586c063
Author: Vladimir Zapolskiy <vz@mleia.com>
Date: Mon Jul 27 00:18:51 2015 +0300
misc: eeprom: at24: clean up at24_bin_write()
The change removes redundant sysfs binary file boundary check, since
this task is already done on caller side in fs/sysfs/file.c
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
commit 1f023297f7f77d434ecc221018d2e181eac0ae36
Author: Vladimir Zapolskiy <vz@mleia.com>
Date: Mon Jul 27 00:16:31 2015 +0300
i2c: slave eeprom: clean up sysfs bin attribute read()/write()
The change removes redundant sysfs binary file boundary checks,
since this task is already done on caller side in fs/sysfs/file.c
Note, on file size overflow read() now returns 0, and this is a
correct and expected EOF notification according to POSIX.
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Do you want me to send them to you again anyway?
--
With best wishes,
Vladimir
next prev parent reply other threads:[~2015-08-07 16:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-26 21:18 [PATCH 0/8] misc: remove boundary checks from bin attr users Vladimir Zapolskiy
2015-07-26 21:18 ` [PATCH 1/8] misc: cxl: clean up afu_read_config() Vladimir Zapolskiy
2015-07-26 23:06 ` Daniel Axtens
2015-08-05 7:48 ` Michael Neuling
2015-07-26 21:18 ` [PATCH 2/8] misc: ds1682: clean up ds1682_eeprom_read() and ds1682_eeprom_write() Vladimir Zapolskiy
2015-07-26 21:18 ` [PATCH 3/8] misc: eeprom: 93xx46: clean up eeprom_93xx46_bin_read/write Vladimir Zapolskiy
2015-07-26 21:18 ` [PATCH 4/8] misc: eeprom: clean up eeprom_read() Vladimir Zapolskiy
2015-07-29 7:14 ` Jean Delvare
2015-07-26 21:18 ` [PATCH 5/8] misc: eeprom: max6875: clean up max6875_read() Vladimir Zapolskiy
2015-07-26 21:18 ` [PATCH 6/8] misc: eeprom: at24: clean up at24_bin_write() Vladimir Zapolskiy
2015-07-28 6:11 ` Wolfram Sang
2015-07-26 21:18 ` [PATCH 7/8] misc: eeprom: at25: move eeprom boundary checks to mem_read/mem_write Vladimir Zapolskiy
2015-07-26 21:18 ` [PATCH 8/8] misc: eeprom: sunxi_sid: clean up sid_read() Vladimir Zapolskiy
2015-08-07 16:10 ` [PATCH 0/8] misc: remove boundary checks from bin attr users Wolfram Sang
2015-08-07 16:15 ` Vladimir Zapolskiy [this message]
2015-08-07 22:34 ` Wolfram Sang
2015-08-08 12:51 ` Vladimir Zapolskiy
2015-08-08 16:49 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C4D9B2.3000708@mleia.com \
--to=vz@mleia.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=imunsie@au1.ibm.com \
--cc=jdelvare@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mikey@neuling.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).