* [PATCH] NULL check value returned by alloc_skb
@ 2021-06-09 9:11 Dhiraj Shah
2021-06-09 12:20 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Dhiraj Shah @ 2021-06-09 9:11 UTC (permalink / raw)
Cc: find.dhiraj, Marcel Holtmann, Johan Hedberg,
Luiz Augusto von Dentz, linux-bluetooth, linux-kernel
Return error ENOMEM if alloc_skb() failed.
Signed-off-by: Dhiraj Shah <find.dhiraj@gmail.com>
---
drivers/bluetooth/virtio_bt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/bluetooth/virtio_bt.c b/drivers/bluetooth/virtio_bt.c
index c804db7e90f8..5f82574236c0 100644
--- a/drivers/bluetooth/virtio_bt.c
+++ b/drivers/bluetooth/virtio_bt.c
@@ -34,6 +34,8 @@ static int virtbt_add_inbuf(struct virtio_bluetooth *vbt)
int err;
skb = alloc_skb(1000, GFP_KERNEL);
+ if (!skb)
+ return -ENOMEM;
sg_init_one(sg, skb->data, 1000);
err = virtqueue_add_inbuf(vq, sg, 1, skb, GFP_KERNEL);
--
2.30.1 (Apple Git-130)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] NULL check value returned by alloc_skb
2021-06-09 9:11 [PATCH] NULL check value returned by alloc_skb Dhiraj Shah
@ 2021-06-09 12:20 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2021-06-09 12:20 UTC (permalink / raw)
To: Dhiraj Shah
Cc: Johan Hedberg, Luiz Augusto von Dentz, Bluez mailing list, linux-kernel
Hi Dhiraj,
> Return error ENOMEM if alloc_skb() failed.
>
> Signed-off-by: Dhiraj Shah <find.dhiraj@gmail.com>
> ---
> drivers/bluetooth/virtio_bt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/virtio_bt.c b/drivers/bluetooth/virtio_bt.c
> index c804db7e90f8..5f82574236c0 100644
> --- a/drivers/bluetooth/virtio_bt.c
> +++ b/drivers/bluetooth/virtio_bt.c
> @@ -34,6 +34,8 @@ static int virtbt_add_inbuf(struct virtio_bluetooth *vbt)
> int err;
>
> skb = alloc_skb(1000, GFP_KERNEL);
> + if (!skb)
> + return -ENOMEM;
> sg_init_one(sg, skb->data, 1000);
>
> err = virtqueue_add_inbuf(vq, sg, 1, skb, GFP_KERNEL);
a similar patch is already upstream in bluetooth-next.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-09 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 9:11 [PATCH] NULL check value returned by alloc_skb Dhiraj Shah
2021-06-09 12:20 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).