From: Eric Auger <eric.auger@linaro.org>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: eric.auger@st.com, feng.wu@intel.com, pbonzini@redhat.com,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
avi.kivity@gmail.com, mtosatti@redhat.com, joro@8bytes.org,
marc.zyngier@arm.com, christoffer.dall@linaro.org,
linux-kernel@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH v4 5/5] KVM: eventfd: add irq bypass consumer management
Date: Mon, 10 Aug 2015 10:44:14 +0200 [thread overview]
Message-ID: <55C8645E.6060505@linaro.org> (raw)
In-Reply-To: <1438978155.4023.263.camel@redhat.com>
Hi Alex,
On 08/07/2015 10:09 PM, Alex Williamson wrote:
> On Mon, 2015-08-03 at 19:20 +0200, Eric Auger wrote:
>> This patch adds the registration/unregistration of an
>> irq_bypass_consumer on irqfd assignment/deassignment.
>>
>> Signed-off-by: Eric Auger <eric.auger@linaro.org>
>> Signed-off-by: Feng Wu <feng.wu@intel.com>
>>
>> ---
>>
>> v2 -> v3 (Feng Wu):
>> - Use kvm_arch_irq_bypass_start
>> - Remove kvm_arch_irq_bypass_update
>> - Add member 'struct irq_bypass_producer *producer' in
>> 'struct kvm_kernel_irqfd', it is needed by posted interrupt.
>> - Remove 'irq_bypass_unregister_consumer' in kvm_irqfd_deassign()
>>
>> v1 -> v2:
>> - populate of kvm and gsi removed
>> - unregister the consumer on irqfd_shutdown
>> ---
>> include/linux/kvm_irqfd.h | 2 ++
>> virt/kvm/eventfd.c | 10 ++++++++++
>> 2 files changed, 12 insertions(+)
>>
>> diff --git a/include/linux/kvm_irqfd.h b/include/linux/kvm_irqfd.h
>> index f926b39..0c1de05 100644
>> --- a/include/linux/kvm_irqfd.h
>> +++ b/include/linux/kvm_irqfd.h
>> @@ -64,6 +64,8 @@ struct kvm_kernel_irqfd {
>> struct list_head list;
>> poll_table pt;
>> struct work_struct shutdown;
>> + struct irq_bypass_consumer consumer;
>> + struct irq_bypass_producer *producer;
>> };
>>
>> #endif /* __LINUX_KVM_IRQFD_H */
>> diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
>> index 647ffb8..08855de 100644
>> --- a/virt/kvm/eventfd.c
>> +++ b/virt/kvm/eventfd.c
>> @@ -35,6 +35,7 @@
>> #include <linux/srcu.h>
>> #include <linux/slab.h>
>> #include <linux/seqlock.h>
>> +#include <linux/irqbypass.h>
>> #include <trace/events/kvm.h>
>>
>> #include <kvm/iodev.h>
>> @@ -140,6 +141,7 @@ irqfd_shutdown(struct work_struct *work)
>> /*
>> * It is now safe to release the object's resources
>> */
>> + irq_bypass_unregister_consumer(&irqfd->consumer);
>> eventfd_ctx_put(irqfd->eventfd);
>> kfree(irqfd);
>> }
>> @@ -380,6 +382,14 @@ kvm_irqfd_assign(struct kvm *kvm, struct kvm_irqfd *args)
>> */
>> fdput(f);
>>
>> + irqfd->consumer.token = (void *)irqfd->eventfd;
>> + irqfd->consumer.add_producer = kvm_arch_irq_bypass_add_producer;
>> + irqfd->consumer.del_producer = kvm_arch_irq_bypass_del_producer;
>> + irqfd->consumer.stop = kvm_arch_irq_bypass_stop;
>> + irqfd->consumer.start = kvm_arch_irq_bypass_start;
>> + ret = irq_bypass_register_consumer(&irqfd->consumer);
>> + WARN_ON(ret);
>
> This seems like a lazy way to handle this error. What is the stack
> trace from this WARN_ON going to tell us that we didn't already know?
> If we get the WARN_ON, it's probably means that an incompatible producer
> registered the token first. It means we can't do bypass, but it doesn't
> tell us anything about whether bypass is or is not enabled. Wouldn't a
> pr_info/debug() suffice for that? Thanks,
Sure I will output some more relevant traces.
Thanks
Eric
>
> Alex
>
>> +
>> return 0;
>>
>> fail:
>
>
>
prev parent reply other threads:[~2015-08-10 8:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 17:20 [PATCH v4 0/5] KVM: irqfd consumer based on IRQ bypass manager Eric Auger
2015-08-03 17:20 ` [PATCH v4 1/5] KVM: x86: select IRQ_BYPASS_MANAGER Eric Auger
2015-08-03 17:20 ` [PATCH v4 2/5] KVM: arm/arm64: " Eric Auger
2015-08-03 17:20 ` [PATCH v4 3/5] KVM: create kvm_irqfd.h Eric Auger
2015-08-03 17:20 ` [PATCH v4 4/5] KVM: introduce kvm_arch functions for IRQ bypass Eric Auger
2015-08-07 20:09 ` Alex Williamson
2015-08-10 8:43 ` Eric Auger
2015-08-03 17:20 ` [PATCH v4 5/5] KVM: eventfd: add irq bypass consumer management Eric Auger
2015-08-07 20:09 ` Alex Williamson
2015-08-10 8:44 ` Eric Auger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C8645E.6060505@linaro.org \
--to=eric.auger@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=avi.kivity@gmail.com \
--cc=christoffer.dall@linaro.org \
--cc=eric.auger@st.com \
--cc=feng.wu@intel.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mtosatti@redhat.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).