From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755174AbbHJJ7H (ORCPT ); Mon, 10 Aug 2015 05:59:07 -0400 Received: from smtp.citrix.com ([66.165.176.89]:44831 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755142AbbHJJ7E (ORCPT ); Mon, 10 Aug 2015 05:59:04 -0400 X-IronPort-AV: E=Sophos;i="5.15,644,1432598400"; d="scan'208";a="289586384" Message-ID: <55C875E6.7050909@citrix.com> Date: Mon, 10 Aug 2015 10:59:02 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Boris Ostrovsky , CC: David Vrabel , , , Subject: Re: [Xen-devel] [PATCH v3 9/9] xen/xenbus: Rename the variable xen_store_mfn to xen_store_gfn References: <1438965282-19103-1-git-send-email-julien.grall@citrix.com> <1438965282-19103-10-git-send-email-julien.grall@citrix.com> <55C52416.1090906@oracle.com> In-Reply-To: <55C52416.1090906@oracle.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, On 07/08/2015 22:33, Boris Ostrovsky wrote: > On 08/07/2015 12:34 PM, Julien Grall wrote: >> The variable xen_store_mfn is effectively storing a GFN and not an MFN. >> >> Signed-off-by: Julien Grall >> >> --- >> Cc: Konrad Rzeszutek Wilk >> Cc: Boris Ostrovsky >> Cc: David Vrabel >> >> I think that the assignation of xen_start_info in >> xenstored_local_init is pointless. Although I haven't drop it just >> in case. > > I think so too (but that would be a separate patch if you decide to do it). I will send a separate patch to drop it. > > Reviewed-by: Boris Ostrovsky Thank you! Regards, -- Julien Grall