From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Vinod Koul <vinod.koul@intel.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
<peter@hurleysoftware.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
<dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<nsekhar@ti.com>, <linux-omap@vger.kernel.org>,
<linux-serial@vger.kernel.org>, <john.ogness@linutronix.de>
Subject: Re: [PATCH 1/3] tty: serial: 8250_omap: do not use RX DMA if pause is not supported
Date: Mon, 10 Aug 2015 14:54:10 +0300 [thread overview]
Message-ID: <55C890E2.50208@ti.com> (raw)
In-Reply-To: <1438977619-15488-2-git-send-email-bigeasy@linutronix.de>
On 08/07/2015 11:00 PM, Sebastian Andrzej Siewior wrote:
> The 8250-omap driver requires the DMA-engine driver to support the pause
> command in order to properly turn off programmed RX transfer before the
> driver stars manually reading from the FIFO.
> The lacking support of the requirement has been discovered recently. In
> order to stay safe here we disable support for RX-DMA as soon as we
> notice that it does not work. This should happen very early.
> If the user does not want to see this backtrace he can either disable
> DMA support (completely or RX-only) or backport the required patches for
> edma / omap-dma once they hit mainline.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> drivers/tty/serial/8250/8250_omap.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
> index 0340ee6ba970..07a11e0935e4 100644
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
> @@ -112,6 +112,7 @@ struct omap8250_priv {
> struct work_struct qos_work;
> struct uart_8250_dma omap8250_dma;
> spinlock_t rx_dma_lock;
> + bool rx_dma_broken;
> };
>
> static u32 uart_read(struct uart_8250_port *up, u32 reg)
> @@ -761,6 +762,7 @@ static void omap_8250_rx_dma_flush(struct uart_8250_port *p)
> struct omap8250_priv *priv = p->port.private_data;
> struct uart_8250_dma *dma = p->dma;
> unsigned long flags;
> + int ret;
>
> spin_lock_irqsave(&priv->rx_dma_lock, flags);
>
> @@ -769,7 +771,9 @@ static void omap_8250_rx_dma_flush(struct uart_8250_port *p)
> return;
> }
>
> - dmaengine_pause(dma->rxchan);
> + ret = dmaengine_pause(dma->rxchan);
> + if (WARN_ON_ONCE(ret))
> + priv->rx_dma_broken = true;
I don't think this is good thing for the stable _and_ for the mainline at the
same time:
in stable the rx DMA should not be allowed since the stable kernels does not
allow pause/resume with omap-dma, so there the rx DMA should be just disabled
for UART. This change will cause regression since it introduce a WARN_ON_ONCE,
which will be printed if the user tries to use non working feature.
In mainline you will eventually going to have pause/resume support so this
patch will make no sense there.
>
> spin_unlock_irqrestore(&priv->rx_dma_lock, flags);
>
> @@ -813,6 +817,9 @@ static int omap_8250_rx_dma(struct uart_8250_port *p, unsigned int iir)
> break;
> }
>
> + if (priv->rx_dma_broken)
> + return -EINVAL;
> +
> spin_lock_irqsave(&priv->rx_dma_lock, flags);
>
> if (dma->rx_running)
>
--
Péter
next prev parent reply other threads:[~2015-08-10 11:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 20:00 omap-dma + 8250_omap: fix the dmaengine_pause() Sebastian Andrzej Siewior
2015-08-07 20:00 ` [PATCH 1/3] tty: serial: 8250_omap: do not use RX DMA if pause is not supported Sebastian Andrzej Siewior
2015-08-08 0:28 ` Peter Hurley
2015-08-08 9:03 ` Russell King - ARM Linux
2015-08-11 9:57 ` Vinod Koul
2015-08-08 9:32 ` Sebastian Andrzej Siewior
2015-08-08 9:57 ` Russell King - ARM Linux
2015-08-08 15:40 ` Greg KH
2015-08-10 11:54 ` Peter Ujfalusi [this message]
2015-08-10 12:19 ` Sebastian Andrzej Siewior
2015-08-10 13:00 ` Peter Hurley
2015-08-10 17:15 ` Russell King - ARM Linux
2015-08-07 20:00 ` [PATCH 2/3] dma: add __must_check annotation for dmaengine_pause() Sebastian Andrzej Siewior
2015-08-08 0:40 ` Peter Hurley
2015-08-11 9:58 ` Vinod Koul
2015-08-11 10:06 ` Russell King - ARM Linux
2015-08-11 12:34 ` Sebastian Andrzej Siewior
2015-08-21 8:32 ` Vinod Koul
2015-08-07 20:00 ` [PATCH v3 3/3] dma: omap-dma: add support for pause of non-cyclic transfers Sebastian Andrzej Siewior
2015-08-11 12:02 ` Peter Ujfalusi
2015-08-11 12:30 ` Russell King - ARM Linux
2015-08-11 12:43 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C890E2.50208@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter@hurleysoftware.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).