From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752633AbbHMJar (ORCPT <rfc822;w@1wt.eu>);
	Thu, 13 Aug 2015 05:30:47 -0400
Received: from mail-pa0-f51.google.com ([209.85.220.51]:36032 "EHLO
	mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751452AbbHMJao (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 13 Aug 2015 05:30:44 -0400
Message-ID: <55CC63BC.4080902@linaro.org>
Date: Thu, 13 Aug 2015 17:30:36 +0800
From: Hanjun Guo <hanjun.guo@linaro.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Timur Tabi <timur@codeaurora.org>, Al Stone <al.stone@linaro.org>
CC: linux-acpi@vger.kernel.org,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        linaro-kernel@lists.linaro.org, linux-ia64@vger.kernel.org,
        patches@linaro.org, linux-pm@vger.kernel.org,
        linaro-acpi@lists.linaro.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        lkml <linux-kernel@vger.kernel.org>, Len Brown <lenb@kernel.org>
Subject: Re: [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry() function
 to eventually replace the macro
References: <1438894770-31163-1-git-send-email-al.stone@linaro.org>	<1438894770-31163-2-git-send-email-al.stone@linaro.org> <CAOZdJXVZomskfpvEjmDUiptW3SndJWvfKyzd9SwJp3dh7h3pig@mail.gmail.com>
In-Reply-To: <CAOZdJXVZomskfpvEjmDUiptW3SndJWvfKyzd9SwJp3dh7h3pig@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/13/2015 06:35 AM, Timur Tabi wrote:
> On Thu, Aug 6, 2015 at 3:59 PM, Al Stone <al.stone@linaro.org> wrote:
>> +       while (ms->num_types != 0) {
>> +               if (ms->major_version == major &&
>> +                   ms->minor_version == minor &&
>> +                   ms->madt_version == madt->header.revision)
>> +                       break;
>> +               ms++;
>> +       }
>> +       if (!ms) {
>
> Shouldn't this be
>
>    if (!ms->num_types) {
>
> instead?

I think so, but seems nothing to do with the FADT version,
Al may explain more about it :)

Thanks
Hanjun