From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428AbbHMPny (ORCPT ); Thu, 13 Aug 2015 11:43:54 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:36595 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753389AbbHMPnt (ORCPT ); Thu, 13 Aug 2015 11:43:49 -0400 Subject: Re: [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro To: Timur Tabi References: <1438894770-31163-1-git-send-email-al.stone@linaro.org> <1438894770-31163-2-git-send-email-al.stone@linaro.org> Cc: linux-acpi@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , linaro-kernel@lists.linaro.org, linux-ia64@vger.kernel.org, patches@linaro.org, linux-pm@vger.kernel.org, linaro-acpi@lists.linaro.org, "Rafael J. Wysocki" , lkml , Len Brown From: Al Stone Message-ID: <55CCBB32.6000103@linaro.org> Date: Thu, 13 Aug 2015 09:43:46 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/12/2015 04:35 PM, Timur Tabi wrote: > On Thu, Aug 6, 2015 at 3:59 PM, Al Stone wrote: >> + while (ms->num_types != 0) { >> + if (ms->major_version == major && >> + ms->minor_version == minor && >> + ms->madt_version == madt->header.revision) >> + break; >> + ms++; >> + } >> + if (!ms) { > > Shouldn't this be > > if (!ms->num_types) { > > instead? > Argh. Yes, it should. It will always be false, otherwise. Will fix for next version. Thanks for catching that. -- ciao, al ----------------------------------- Al Stone Software Engineer Linaro Enterprise Group al.stone@linaro.org -----------------------------------