From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753783AbbHNIY7 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 14 Aug 2015 04:24:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59737 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753218AbbHNIYz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 14 Aug 2015 04:24:55 -0400
Subject: Re: [Intel-gfx] [4.2-rc4] acpi|drm|i915: circular locking dependency:
 acpi_video_get_backlight_type
To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
        Sedat Dilek <sedat.dilek@gmail.com>
References: <CA+icZUWh+qH0KuF7dcc0gJxM9myssapbPbOboeMoc-WjU-TK+A@mail.gmail.com>
 <CA+icZUWitjMzjhLKs+NLAaUdxQxkW7PNZ19HQfmi8oy2qmC1rA@mail.gmail.com>
 <CA+icZUVoUx3qMp7oChVyo8yN6D+Juf3VHqs25aCKShN1czkROw@mail.gmail.com>
 <20150812192620.GN5176@intel.com> <55CCAACF.7040109@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Dave Airlie <airlied@redhat.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>,
        Linux ACPI <linux-acpi@vger.kernel.org>,
        intel-gfx <intel-gfx@lists.freedesktop.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>
From: Hans de Goede <hdegoede@redhat.com>
Message-ID: <55CDA5D3.9030606@redhat.com>
Date: Fri, 14 Aug 2015 10:24:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <55CCAACF.7040109@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 13-08-15 16:33, Hans de Goede wrote:
> Hi,
>
> On 12-08-15 21:26, Ville Syrjälä wrote:
>> On Mon, Aug 10, 2015 at 08:29:00PM +0200, Sedat Dilek wrote:
>>> On Sat, Aug 1, 2015 at 2:23 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>>>> On Mon, Jul 27, 2015 at 12:33 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>>>>> Hi,
>>>>>
>>>>> this my first build of a 4.2-rcN Linux-kernel and I see this...
>>>>>
>>>>
>>>> Just FYI:
>>>>
>>>> I am *not* seeing this with drm-intel-nightly from below url.
>>>>
>>>> Also, I plan to test Linux v4.2-rc5.
>>>>
>>>
>>> [ CC Linus ]
>>>
>>> Knock Knock Knock.
>>>
>>> This issue still remains here (with CONFIG_DRM_I915=m)...
>>>
>>> [   18.269792] ======================================================
>>> [   18.269798] [ INFO: possible circular locking dependency detected ]
>>> [   18.269805] 4.2.0-rc6-1-iniza-small #1 Not tainted
>>> [   18.269810] -------------------------------------------------------
>>> [   18.269816] modprobe/727 is trying to acquire lock:
>>> [   18.269822]  (init_mutex){+.+.+.}, at: [<ffffffffa0090f2d>]
>>> acpi_video_get_backlight_type+0x17/0x164 [video]
>>> [   18.269840]
>>> [   18.269840] but task is already holding lock:
>>> [   18.269848]  (&(&backlight_notifier)->rwsem){++++..}, at:
>>> [<ffffffff810a6519>] __blocking_notifier_call_chain+0x39/0x70
>>> [   18.269864]
>>> [   18.269864] which lock already depends on the new lock.
>>> [   18.269864]
>>> [   18.269875]
>>> [   18.269875] the existing dependency chain (in reverse order) is:
>>> [   18.269884]
>>> ...
>>>
>>> Full dmesg log and kernel-config attached.
>>>
>>> Shall I add Rusty and modules/modprobe folks?
>>
>> Just got back from vacation and was greeted by this same lockdep splat.
>>
>> On a hunch I reverted
>>
>> commit 93a291dfaf9c328ca5a9cea1733af1a128efe890
>> Author: Hans de Goede <hdegoede@redhat.com>
>> Date:   Tue Jun 16 16:27:52 2015 +0200
>>
>>      ACPI / video: Move backlight notifier to video_detect.c
>>
>> and the problem seems to be gone. Hans, any thoughts?
>
> Looking into this atm, lockdep clearly is right.
>
> Sorry about this I have put a lot of thinking into avoiding
> these kind of issues with this patch-set, but I did not realize
> there was another lock "hiding" inside the notifier-chain.
>
> Further analysis shows that the lock inside the notifier-chain
> causes similar problems vs register_count_mutex from
> drivers/acpi/acpi_video.c. I'm working on a fix for this
> atm.

Heh, look at what I just found (I'm shifting my work focus
in the direction of nouveau) :

https://bugzilla.redhat.com/show_bug.cgi?id=1152876

So it looks like we have had the root cause of this issue
for a long time already, maybe my recent backlight selection
logic cleanup / rework has made it easier to trigger the
lockdep warning for this though.

Anyhow assuming people are ok with the fix I submitted
yesterday we've a fix for this now.

Regards,

Hans