From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: keescook@chromium.org, jwboyer@redhat.com, smueller@chronox.de,
richard@nod.at, steved@redhat.com, linux-kernel@vger.kernel.org,
dhowells@redhat.com, linux-crypto@vger.kernel.org,
james.l.morris@oracle.com, jkosina@suse.cz,
zohar@linux.vnet.ibm.com, davem@davemloft.net, vgoyal@redhat.com
Subject: Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer
Date: Fri, 14 Aug 2015 07:24:23 -0700 [thread overview]
Message-ID: <55CDFA17.3090100@intel.com> (raw)
In-Reply-To: <20150814062636.GA2799@gondor.apana.org.au>
On 08/13/2015 11:26 PM, Herbert Xu wrote:
> On Thu, Aug 13, 2015 at 11:14:11PM -0700, Tadeusz Struk wrote:
>>
>> Right, but we don't need that anymore.
>
> Why not? If you reduce the size without moving the buffer wouldn't
> it begin with a bunch of zeroes and wouldn't you lose the real bytes
> at the end?
>
If you don't like the first option then we still need this, as you pointed out.
---8<---
Change memcpy to memmove because the copy is done within the same buffer.
diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/crypto/qat/qat_common/qat_asym_algs.c
index fe352a6..e87f510 100644
--- a/drivers/crypto/qat/qat_common/qat_asym_algs.c
+++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c
@@ -145,7 +145,7 @@ static void qat_rsa_cb(struct icp_qat_fw_pke_resp *resp)
}
if (areq->dst_len != req->ctx->key_sz)
- memcpy(areq->dst, ptr, areq->dst_len);
+ memmove(areq->dst, ptr, areq->dst_len);
akcipher_request_complete(areq, err);
}
next prev parent reply other threads:[~2015-08-14 14:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 3:54 [PATCH 0/2] crypto: KEYS: convert public key to the akcipher API Tadeusz Struk
2015-08-13 3:54 ` [PATCH 1/2] " Tadeusz Struk
2015-08-15 18:08 ` Stephan Mueller
2015-08-24 17:45 ` Tadeusz Struk
2015-08-13 3:54 ` [PATCH 2/2] crypto: qat - Don't move data inside output buffer Tadeusz Struk
2015-08-13 16:40 ` Tadeusz Struk
2015-08-14 5:14 ` Herbert Xu
2015-08-14 6:14 ` Tadeusz Struk
2015-08-14 6:26 ` Herbert Xu
2015-08-14 14:21 ` Tadeusz Struk
2015-08-17 8:48 ` Herbert Xu
2015-08-14 14:24 ` Tadeusz Struk [this message]
2015-08-17 8:50 ` Herbert Xu
2015-08-18 1:05 ` Tadeusz Struk
2015-08-18 2:39 ` Herbert Xu
2015-08-13 13:56 ` [PATCH 0/2] crypto: KEYS: convert public key to the akcipher API David Howells
2015-08-13 16:44 ` Tadeusz Struk
2015-08-13 14:23 ` [PATCH 1/2] " David Howells
2015-08-13 16:47 ` Tadeusz Struk
2015-08-14 1:09 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CDFA17.3090100@intel.com \
--to=tadeusz.struk@intel.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=james.l.morris@oracle.com \
--cc=jkosina@suse.cz \
--cc=jwboyer@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=smueller@chronox.de \
--cc=steved@redhat.com \
--cc=vgoyal@redhat.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).