From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752142AbbHQGvS (ORCPT ); Mon, 17 Aug 2015 02:51:18 -0400 Received: from mga01.intel.com ([192.55.52.88]:24324 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbbHQGvQ (ORCPT ); Mon, 17 Aug 2015 02:51:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,693,1432623600"; d="scan'208";a="785444236" Message-ID: <55D183C1.1030209@intel.com> Date: Mon, 17 Aug 2015 09:48:33 +0300 From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: "Fu, Zhonghui" , Ulf Hansson , neilb@suse.de, Jaehoon Chung , afenkart@gmail.com, joe@perches.com CC: linux-mmc , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] MMC/SDIO: enable SDIO device to suspend/resume asynchronously References: <55B9D4EF.2010704@linux.intel.com> <55D1546D.1070900@linux.intel.com> In-Reply-To: <55D1546D.1070900@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/08/15 06:26, Fu, Zhonghui wrote: > > Hi, > > Any comments are welcome. > > > Thanks, > Zhonghui > > On 2015/7/30 15:40, Fu, Zhonghui wrote: >> Enable SDIO card and function device to suspend/resume asynchronously. >> This can improve system suspend/resume speed. For me, it needs more explanation. For example, why is this worth doing? Can you give an example where it does significantly improve suspend/resume speed? Are there any cases where it could be worse? Why is it safe? Presumably it is safe if there are no dependencies on the device outside the device hierarchy. Is that so? Are there any other potential pitfalls to enabling async_suspend? >> >> Signed-off-by: Zhonghui Fu >> --- >> drivers/mmc/core/sdio.c | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c >> index b91abed..6719b77 100644 >> --- a/drivers/mmc/core/sdio.c >> +++ b/drivers/mmc/core/sdio.c >> @@ -1106,6 +1106,8 @@ int mmc_attach_sdio(struct mmc_host *host) >> pm_runtime_enable(&card->dev); >> } >> >> + device_enable_async_suspend(&card->dev); >> + >> /* >> * The number of functions on the card is encoded inside >> * the ocr. >> @@ -1126,6 +1128,8 @@ int mmc_attach_sdio(struct mmc_host *host) >> */ >> if (host->caps & MMC_CAP_POWER_OFF_CARD) >> pm_runtime_enable(&card->sdio_func[i]->dev); >> + >> + device_enable_async_suspend(&card->sdio_func[i]->dev); >> } >> >> /* >> -- 1.7.1 >> > > >