From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Sekhar Nori <nsekhar@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH] gpiolib: irqchip: use different lockdep class for each gpio irqchip
Date: Mon, 17 Aug 2015 12:40:08 +0300 [thread overview]
Message-ID: <55D1ABF8.1070809@ti.com> (raw)
In-Reply-To: <CACRpkdYtUWc7X5d8mGbZK9dTgKmi1vqYZKK3Ho6mdH5MTE8K8g@mail.gmail.com>
On 08/14/2015 03:34 PM, Linus Walleij wrote:
> On Thu, Aug 13, 2015 at 4:58 PM, Grygorii Strashko
> <grygorii.strashko@ti.com> wrote:
>
>> Since IRQ chip helpers were introduced drivers lose ability to
>> register separate lockdep classes for each registered GPIO IRQ
>> chip and the gpiolib now is using shared lockdep class for
>> all GPIO IRQ chips (gpiochip_irq_lock_class).
>> As result, lockdep will produce warning when there are min two
>> stacked GPIO chips and all of them are interrupt controllers.
>>
>> HW configuration which generates lockdep warning (TI dra7-evm):
> (...)
>>
>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>> Cc: Roger Quadros <rogerq@ti.com>
>> Reported-by: Roger Quadros <rogerq@ti.com>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
> Ah, I see...
>
>
>> * implies that if the chip supports IRQs, these IRQs need to be threaded
>> * as the chip access may sleep when e.g. reading out the IRQ status
>> * registers.
>> + * @exported: flags if the gpiochip is exported for use from sysfs. Private.
>> * @irq_not_threaded: flag must be set if @can_sleep is set but the
>> * IRQs don't need to be threaded
>> *
>> @@ -126,6 +128,7 @@ struct gpio_chip {
>> irq_flow_handler_t irq_handler;
>> unsigned int irq_default_type;
>> int irq_parent;
>> + struct lock_class_key *lock_key;
>
> There is something weird with the kerneldoc. It is documenting something
> else but not documenting the new member.
>
Sorry, for that.
There are no kerneldocs for any of GPIO IRQ chip's specific fields,
Do you prefer me to add doc for "lock_key" or all of them?
--
regards,
-grygorii
prev parent reply other threads:[~2015-08-17 9:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 14:58 [PATCH] gpiolib: irqchip: use different lockdep class for each gpio irqchip Grygorii Strashko
2015-08-14 9:00 ` Roger Quadros
2015-08-14 12:34 ` Linus Walleij
2015-08-14 12:40 ` Lars-Peter Clausen
2015-08-14 13:05 ` Grygorii Strashko
2015-08-17 9:06 ` Linus Walleij
2015-08-17 9:40 ` Grygorii Strashko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D1ABF8.1070809@ti.com \
--to=grygorii.strashko@ti.com \
--cc=geert@linux-m68k.org \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).