From: Julien Grall <julien.grall@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>, <xen-devel@lists.xenproject.org>
Cc: Jiri Slaby <jslaby@suse.cz>, <ian.campbell@citrix.com>,
<stefano.stabellini@eu.citrix.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
<linuxppc-dev@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [Xen-devel] [PATCH v3 11/20] tty/hvc: xen: Use xen page definition
Date: Fri, 28 Aug 2015 16:03:14 +0100 [thread overview]
Message-ID: <55E07832.1010802@citrix.com> (raw)
In-Reply-To: <55D5A42E.7070800@citrix.com>
Hi David,
On 20/08/15 10:55, David Vrabel wrote:
> On 07/08/15 17:46, Julien Grall wrote:
>> The console ring is always based on the page granularity of Xen.
> [...]
>> --- a/drivers/tty/hvc/hvc_xen.c
>> +++ b/drivers/tty/hvc/hvc_xen.c
>> @@ -230,7 +230,7 @@ static int xen_hvm_console_init(void)
>> if (r < 0 || v == 0)
>> goto err;
>> gfn = v;
>> - info->intf = xen_remap(gfn << PAGE_SHIFT, PAGE_SIZE);
>> + info->intf = xen_remap(gfn << XEN_PAGE_SHIFT, PAGE_SIZE);
>
> You need XEN_PAGE_SIZE here I think...
Right, I did the mistake while rebase on my s/mfn/gfn/ series. I will
fix it in the next version.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-08-28 15:06 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 16:46 [PATCH v3 00/20] xen/arm64: Add support for 64KB page Julien Grall
2015-08-07 16:46 ` [PATCH v3 01/20] net/xen-netback: xenvif_gop_frag_copy: move GSO check out of the loop Julien Grall
2015-08-08 13:59 ` Wei Liu
2015-08-07 16:46 ` [PATCH v3 02/20] arm/xen: Drop pte_mfn and mfn_pte Julien Grall
2015-08-10 10:10 ` Stefano Stabellini
2015-08-07 16:46 ` [PATCH v3 03/20] xen: Add Xen specific page definition Julien Grall
2015-08-10 10:46 ` Stefano Stabellini
2015-08-20 9:49 ` [Xen-devel] " David Vrabel
2015-08-07 16:46 ` [PATCH v3 04/20] xen/grant: Introduce helpers to split a page into grant Julien Grall
2015-08-10 10:44 ` Stefano Stabellini
2015-08-20 9:51 ` [Xen-devel] " David Vrabel
2015-08-28 14:29 ` Julien Grall
2015-08-07 16:46 ` [PATCH v3 05/20] xen/grant: Add helper gnttab_page_grant_foreign_access_ref_one Julien Grall
2015-08-07 16:46 ` [PATCH v3 06/20] block/xen-blkfront: Split blkif_queue_request in 2 Julien Grall
2015-08-07 16:46 ` [PATCH v3 07/20] block/xen-blkfront: Store a page rather a pfn in the grant structure Julien Grall
2015-08-07 16:46 ` [PATCH v3 08/20] block/xen-blkfront: split get_grant in 2 Julien Grall
2015-08-20 7:33 ` Roger Pau Monné
2015-08-07 16:46 ` [PATCH v3 09/20] xen/biomerge: Don't allow biovec to be merge when Linux is not using 4KB page Julien Grall
2015-08-10 10:50 ` Stefano Stabellini
2015-08-10 11:24 ` [Xen-devel] " Julien Grall
2015-08-10 11:25 ` Stefano Stabellini
2015-08-10 11:32 ` Julien Grall
2015-08-10 12:41 ` David Vrabel
2015-08-07 16:46 ` [PATCH v3 10/20] xen/xenbus: Use Xen page definition Julien Grall
2015-08-07 16:46 ` [PATCH v3 11/20] tty/hvc: xen: Use xen " Julien Grall
2015-08-20 9:55 ` [Xen-devel] " David Vrabel
2015-08-28 15:03 ` Julien Grall [this message]
2015-08-07 16:46 ` [PATCH v3 12/20] xen/balloon: Don't rely on the page granularity is the same for Xen and Linux Julien Grall
2015-08-10 11:18 ` Stefano Stabellini
2015-08-10 11:31 ` Julien Grall
2015-08-10 12:55 ` Stefano Stabellini
2015-08-10 13:36 ` Julien Grall
2015-08-20 9:59 ` [Xen-devel] " David Vrabel
2015-08-28 15:10 ` Julien Grall
2015-08-07 16:46 ` [PATCH v3 13/20] xen/events: fifo: Make it running on 64KB granularity Julien Grall
2015-08-07 16:46 ` [PATCH v3 14/20] xen/grant-table: " Julien Grall
2015-08-07 16:46 ` [PATCH v3 15/20] block/xen-blkfront: Make it running on 64KB page granularity Julien Grall
2015-08-20 8:10 ` Roger Pau Monné
2015-08-28 15:33 ` Julien Grall
2015-08-07 16:46 ` [PATCH v3 16/20] block/xen-blkback: " Julien Grall
2015-08-20 8:14 ` Roger Pau Monné
2015-08-07 16:46 ` [PATCH v3 17/20] net/xen-netfront: " Julien Grall
2015-08-20 10:03 ` [Xen-devel] " David Vrabel
2015-08-07 16:46 ` [PATCH v3 18/20] net/xen-netback: " Julien Grall
2015-08-08 14:55 ` Wei Liu
2015-08-10 9:57 ` Julien Grall
2015-08-10 11:39 ` Wei Liu
2015-08-10 12:00 ` Julien Grall
2015-08-07 16:46 ` [PATCH v3 19/20] xen/privcmd: Add support for Linux " Julien Grall
2015-08-10 12:03 ` Stefano Stabellini
2015-08-10 12:14 ` [Xen-devel] " David Vrabel
2015-08-10 12:57 ` Stefano Stabellini
2015-08-10 13:25 ` Julien Grall
2015-09-01 17:10 ` Julien Grall
2015-08-20 10:08 ` [Xen-devel] " David Vrabel
2015-08-07 16:46 ` [PATCH v3 20/20] arm/xen: Add support for " Julien Grall
2015-08-10 12:52 ` Stefano Stabellini
2015-08-07 17:11 ` [Xen-devel] [PATCH v3 00/20] xen/arm64: Add support for 64KB page Julien Grall
2015-08-20 0:40 ` Julien Grall
2015-08-20 8:15 ` Roger Pau Monné
2015-08-20 10:11 ` David Vrabel
2015-08-20 15:03 ` Julien Grall
2015-08-20 15:15 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E07832.1010802@citrix.com \
--to=julien.grall@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=gregkh@linuxfoundation.org \
--cc=ian.campbell@citrix.com \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).