From: Guenter Roeck <linux@roeck-us.net>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
"pi-cheng.chen" <pi-cheng.chen@linaro.org>,
Alexei Starovoitov <ast@plumgrid.com>,
Mark Brown <broonie@kernel.org>,
Markus Pargmann <mpa@pengutronix.de>
Subject: Re: linux-next: Tree for Aug 31 (new arm, arm64, s390 failures)
Date: Mon, 31 Aug 2015 11:57:14 -0700 [thread overview]
Message-ID: <55E4A38A.6070306@roeck-us.net> (raw)
In-Reply-To: <20150831192657.557e45cc@why.wild-wind.fr.eu.org>
Hi Marc,
On 08/31/2015 11:26 AM, Marc Zyngier wrote:
[ ... ]
>
> Actually, the kernel dies because of this:
>
> commit adaac459759db4a1fd35baddbe47bac700095496
> Author: Markus Pargmann <mpa@pengutronix.de>
> Date: Sun Aug 30 09:33:53 2015 +0200
>
> regmap: Introduce max_raw_read/write for regmap_bulk_read/write
>
> There are some buses which have a limit on the maximum number of
> bytes that can be send/received. An example for this is
> I2C_FUNC_SMBUS_I2C_BLOCK which does not support any reads/writes of
> more than 32 bytes. The regmap_bulk operations should still be able
> to utilize the full 32 bytes in this case.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> Signed-off-by: Mark Brown <broonie@kernel.org>
>
> which never considers bus to be NULL in __regmap_init. With the
> following patch applied, I can boot to a prompt:
>
> From 031eae5a1b34f952ba3dcaecb4eb4ec9d3bda352 Mon Sep 17 00:00:00 2001
> From: Marc Zyngier <marc.zyngier@arm.com>
> Date: Mon, 31 Aug 2015 19:16:16 +0100
> Subject: [PATCH] regmap: Fix max_raw_read/write handling when bus is NULL
>
> Commit adaac459759d ("regmap: Introduce max_raw_read/write
> for regmap_bulk_read/write") added new fields to regmap_bus
> and started using them in __regmap_init, but failed to
> consider the case where bus would be NULL, like in the
> vexpress-syscgf case. The box (actually its qemu version)
> ends up dying painfully.
>
> Fix it by testing bus before doing anything else.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Yes, that fixes the vexpress failures.
Tested-by: Guenter Roeck <linux@roeck-us.net>
However, I still need to revert your patches to get my realview-pb-a8
and realview-eb tests to work again.
I am a bit concerned about the use of of_address_to_resource(),
which can return an error, leaving cpu_res undefined. Also, if
both CONFIG_OF and CONFIG_ACPI are not configured, supports_deactivate
is set to true by default. This is the configuration used in my
failing tests.
With that in mind, I ran a simple test.
-static struct static_key supports_deactivate = STATIC_KEY_INIT_TRUE;
+static struct static_key supports_deactivate = STATIC_KEY_INIT_FALSE;
Bingo, problem solved. Can you try to find a clean solution ?
I wonder how it comes that you get a console output from qemu, but I don't.
Did you use multi_v7_defconfig or some other configuration ?
Thanks,
Guenter
next prev parent reply other threads:[~2015-08-31 18:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 9:54 linux-next: Tree for Aug 31 Stephen Rothwell
2015-08-31 14:17 ` linux-next: Tree for Aug 31 (new arm, arm64, s390 failures) Guenter Roeck
2015-08-31 15:09 ` Alexei Starovoitov
2015-08-31 15:31 ` Marc Zyngier
2015-08-31 15:47 ` Guenter Roeck
2015-08-31 16:18 ` Marc Zyngier
2015-08-31 16:40 ` Guenter Roeck
2015-08-31 17:09 ` Marc Zyngier
2015-08-31 18:26 ` Marc Zyngier
2015-08-31 18:57 ` Guenter Roeck [this message]
2015-08-31 19:13 ` Marc Zyngier
2015-08-31 19:40 ` Guenter Roeck
2015-08-31 20:07 ` Mark Brown
2015-08-31 18:33 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E4A38A.6070306@roeck-us.net \
--to=linux@roeck-us.net \
--cc=ast@plumgrid.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mpa@pengutronix.de \
--cc=pi-cheng.chen@linaro.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).