From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754723AbbIJQeL (ORCPT ); Thu, 10 Sep 2015 12:34:11 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:34591 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753984AbbIJQeI (ORCPT ); Thu, 10 Sep 2015 12:34:08 -0400 Subject: Re: [PATCH v3 2/4] clk: qcom: Add support for RCGs with shared branches To: Stephen Boyd References: <1439477317-1902-1-git-send-email-georgi.djakov@linaro.org> <1439477317-1902-3-git-send-email-georgi.djakov@linaro.org> <20150909224613.GW15099@codeaurora.org> Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org From: Georgi Djakov Message-ID: <55F1B0FD.4050406@linaro.org> Date: Thu, 10 Sep 2015 19:34:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150909224613.GW15099@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/2015 01:46 AM, Stephen Boyd wrote: > On 08/13, Georgi Djakov wrote: [..] >> diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c >> index 9aec1761fd29..681faf2dcdc5 100644 >> --- a/drivers/clk/qcom/clk-rcg2.c >> +++ b/drivers/clk/qcom/clk-rcg2.c >> + >> +static int clk_rcg2_shared_enable(struct clk_hw *hw) >> +{ >> + struct clk_rcg2 *rcg = to_clk_rcg2(hw); >> + const char *name = clk_hw_get_name(hw); >> + >> + if (!rcg->current_freq) { >> + pr_err("%s: Please set rate before enabling\n", name); > > Why? Can't we find the current freq during recalc_rate? > Yes, thank you!