From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752457AbbIONmw (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Sep 2015 09:42:52 -0400
Received: from mailout3.w1.samsung.com ([210.118.77.13]:59302 "EHLO
	mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751477AbbIONmu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Sep 2015 09:42:50 -0400
X-AuditID: cbfec7f4-f79c56d0000012ee-96-55f82058f4c6
Subject: Re: [PATCH] coccinelle: tests: unsigned value cannot be lesser than
 zero
To: SF Markus Elfring <elfring@users.sourceforge.net>
References: <1442309232-5902-1-git-send-email-a.hajda@samsung.com>
 <55F816BC.5050407@users.sourceforge.net>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Gilles Muller <Gilles.Muller@lip6.fr>, Joe Perches <joe@perches.com>,
        Nicolas Palix <nicolas.palix@imag.fr>, Michal Marek <mmarek@suse.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        cocci@systeme.lip6.fr
From: Andrzej Hajda <a.hajda@samsung.com>
Message-id: <55F8204D.3080606@samsung.com>
Date: Tue, 15 Sep 2015 15:42:37 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-version: 1.0
In-reply-to: <55F816BC.5050407@users.sourceforge.net>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrALMWRmVeSWpSXmKPExsVy+t/xa7oRCj9CDd6clrDYOGM9q8WPTavZ
	LM53Lme2mP3zEpPF7PuPWSy23pK2uLxrDpvFnNZZbBbHXi5ncuD0OHasldlj75Ysjy+rrjF7
	9G1ZxeixfstVFo9Hy+6zeDSdamf1+LxJLoAjissmJTUnsyy1SN8ugStj8sNjjAW72Sv29PQw
	NTA+ZO1i5OSQEDCRmLVxOROELSZx4d56ti5GLg4hgaWMErfm3oVynjNK/Ln6jR2kSlggWGLm
	vvssXYwcHCICphJ/ToSAhIUEciUWdZwDq2cWWMwksWbxFzaQBJuApsTfzTfBbF4BLYk3696C
	bWMRUJXYevEN2ExRgQiJU2ffQtUISvyYfA9sPifQ/B9v3EFMZgF1iSlTckEqmAXkJTavecs8
	gVFgFpKGWQhVs5BULWBkXsUomlqaXFCclJ5rqFecmFtcmpeul5yfu4kREg9fdjAuPmZ1iFGA
	g1GJhzei/XuoEGtiWXFl7iFGCQ5mJRFeWY4foUK8KYmVValF+fFFpTmpxYcYpTlYlMR55+56
	HyIkkJ5YkpqdmlqQWgSTZeLglGpgDLnz1/O9qO0uFYPDxj6Xj3a/1kic+0CRu1hbJHDJ/ycb
	AldY398iPrH+bHjMhvSsliCnjkUq9twfK73mhUk8/Bq61/bS/N6N9iYCd6fs+2kps8c+sn2i
	YOpdwT0V4fZCJ398N5PPL9n4qceS7aFZAv/0h5wzM04vlPrAeS/wctR189J8wQXTlViKMxIN
	tZiLihMBUU+2tIMCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/15/2015 03:01 PM, SF Markus Elfring wrote:
>> +@r depends on context || org || report@
>> +position p;
>> +typedef u8, u16, u32, u64;
> Can the involved data types be restricted for unsigned types for such
> a source code analysis in a more general way?

I am not sure if I understand correctly. If you think about removing all u*
typedefs it
will result in omitting u* related comparisons, unless you use
--recursive-includes option.
Another solution is to add '--include include/asm-generic/int-ll64.h' to kbuild,
surprisingly
this header file is common for all architectures :)

Regards
Andrzej

>
>
>> +{unsigned char, unsigned short int, unsigned int, unsigned long, unsigned long long, size_t, u8, u16, u32, u64} v;
>> +@@
>> +
>> +(
>> +*v@p < 0
>> +|
>> +*v@p >= 0
>> +)
> How do you think about to use the following SmPL wording instead?
>
>  v@p
> (
> *< 0
> |
> *<= 0
> )
>
> Regards,
> Markus
>