From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752546AbbIONv3 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Sep 2015 09:51:29 -0400
Received: from mailout3.w1.samsung.com ([210.118.77.13]:59877 "EHLO
	mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751760AbbIONv1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Sep 2015 09:51:27 -0400
X-AuditID: cbfec7f5-f794b6d000001495-bd-55f8225d3dd5
Subject: Re: [PATCH] coccinelle: tests: unsigned value cannot be lesser than
 zero
To: Julia Lawall <julia.lawall@lip6.fr>,
        SF Markus Elfring <elfring@users.sourceforge.net>
References: <1442309232-5902-1-git-send-email-a.hajda@samsung.com>
 <55F816BC.5050407@users.sourceforge.net>
 <alpine.DEB.2.10.1509151505240.2537@hadrien>
 <55F81A31.3040808@users.sourceforge.net>
 <alpine.DEB.2.10.1509151530190.2537@hadrien>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Gilles Muller <Gilles.Muller@lip6.fr>, Joe Perches <joe@perches.com>,
        Nicolas Palix <nicolas.palix@imag.fr>, Michal Marek <mmarek@suse.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        cocci@systeme.lip6.fr
From: Andrzej Hajda <a.hajda@samsung.com>
Message-id: <55F82252.4090900@samsung.com>
Date: Tue, 15 Sep 2015 15:51:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-version: 1.0
In-reply-to: <alpine.DEB.2.10.1509151530190.2537@hadrien>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsVy+t/xa7qxSj9CDR5clrfYOGM9q8WPTavZ
	LM53Lme2mP3zEpPF7PuPWSyWPTjNaLH1lrTF5V1z2CzmtM5iszj2cjmTA5fHsWOtzB57t2R5
	fFl1jdmjb8sqRo/1W66yeDxadp/Fo+lUO6vH501yARxRXDYpqTmZZalF+nYJXBmXXm5mLDjA
	XvF5zlLWBsabrF2MHBwSAiYSV96adzFyApliEhfurWfrYuTiEBJYyijxeep7RgjnOaPE+mOL
	WEGqhAWCJWbuu88CYosIxEjsWdXEDFH0jVHi5pmV7CAOs8BiJok1i7+wgVSxCWhK/N18E8zm
	FdCS6Gj9wAhiswioSnw/cBxskqhAhMSps2+hagQlfky+BxbnFLCU6DoxjRnkVGYBdYkpU3JB
	wswC8hKb17xlnsAoMAtJxyyEqllIqhYwMq9iFE0tTS4oTkrPNdIrTswtLs1L10vOz93ECImO
	rzsYlx6zOsQowMGoxMMb0f49VIg1say4MvcQowQHs5IIryzHj1Ah3pTEyqrUovz4otKc1OJD
	jNIcLErivDN3vQ8REkhPLEnNTk0tSC2CyTJxcEo1MM57Y9wbcbiGYeqiq3PaBLYfv/dzsW6Q
	+rFer42H1/yUduZavGj6abNyr7cGJ2rYOMJntSQsCvcv3DuZi9XopebD1MnMU45nv93W8SVg
	4bz6cuZZXX1qn46fbz3w9qpSz5+rd09xCBxeVszfdnYHr9fSlhOxPin3XEtfKQSmNlrenC65
	T2PfjTolluKMREMt5qLiRADeNN4uigIAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/15/2015 03:31 PM, Julia Lawall wrote:
> On Tue, 15 Sep 2015, SF Markus Elfring wrote:
>
>>>>  v@p
>>>> (
>>>> *< 0
>>>> |
>>>> *<= 0
>>>> )
>>> It does not, and is not intended to, work.  The branches of a disjunction
>>> should be complete expressions.
>> Will the following SmPL approach be more appropriate then?
>>
>> (
>> *v@p < 0
>> |
>> *v@p <= 0
>> )
> Actually, all of
>
> v < 0 (never true)
> v <= 0 (same as v == 0)
> v >= 0 (always true)
>
> would seem to merit attention.  Andrzej, what do you think?

You are right, the 2nd case should be also addressed,
such code is misleading.
I will prepare then 2nd version of the patch.

Regards
Andrzej

>
> julia
>
>
>> Regards,
>> Markus
>> --
>> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>