From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753186AbbIPJ1N (ORCPT ); Wed, 16 Sep 2015 05:27:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43542 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752286AbbIPJ1K (ORCPT ); Wed, 16 Sep 2015 05:27:10 -0400 From: Paolo Bonzini Subject: Re: [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' To: Feng Wu , alex.williamson@redhat.com, joro@8bytes.org, mtosatti@redhat.com References: <1442393409-2623-1-git-send-email-feng.wu@intel.com> <1442393409-2623-10-git-send-email-feng.wu@intel.com> Cc: eric.auger@linaro.org, kvm@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Message-ID: <55F935E9.6070707@redhat.com> Date: Wed, 16 Sep 2015 11:27:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442393409-2623-10-git-send-email-feng.wu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/09/2015 10:50, Feng Wu wrote: > +int kvm_arch_update_irqfd_routing(struct kvm *kvm, unsigned int host_irq, > + uint32_t guest_irq, bool set) > +{ > + return !kvm_x86_ops->update_pi_irte ? -EINVAL : > + kvm_x86_ops->update_pi_irte(kvm, host_irq, guest_irq, set); > +} > + Just use "if" here. No need to resend if this is the only comment. > > } > +int __attribute__((weak)) kvm_arch_update_irqfd_routing( > + struct kvm *kvm, unsigned Empty line after "}". Paolo