From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753508AbbIPJx1 (ORCPT ); Wed, 16 Sep 2015 05:53:27 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:33134 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752958AbbIPJxZ (ORCPT ); Wed, 16 Sep 2015 05:53:25 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-60-55f93c1352ed Subject: Re: [PATCH 02/31] arch/ia64/tioce: use kmemdup rather than duplicating its implementation To: Tony Luck , Fenghua Yu References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-3-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org From: Andrzej Hajda Message-id: <55F93C07.1050403@samsung.com> Date: Wed, 16 Sep 2015 11:53:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1438934377-4922-3-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFLMWRmVeSWpSXmKPExsVy+t/xy7rCNj9DDVYd4bXYOGM9q0XbNEeL Dx3vWC0u75rDZrH2yF12izcX7rE4sHks3vOSyaNvyypGj8+b5AKYo7hsUlJzMstSi/TtErgy LrdcYy24ylnxb9IU1gbGHo4uRk4OCQETif7fB9ghbDGJC/fWs3UxcnEICSxllDhwcy4rhPOc UeLYhhtAGQ4OYYEUif+HC0EaRATcJOac+sIIYgsJVEssXrubGaSeWWAxo8T8j9PAEmwCmhJ/ N99kA7F5BbQkehd/YAaxWQRUJXpezGYFsUUFIiROnX0LVSMo8WPyPRYQm1PAWeLe7/fsIHuZ BfQk7l/UAgkzC8hLbF7zlnkCo8AsJB2zEKpmIalawMi8ilE0tTS5oDgpPddQrzgxt7g0L10v OT93EyMkhL/sYFx8zOoQowAHoxIPr8PLH6FCrIllxZW5hxglOJiVRHgjFX6GCvGmJFZWpRbl xxeV5qQWH2KU5mBREuedu+t9iJBAemJJanZqakFqEUyWiYNTqoGxOb4tNuvyK3OlxSGtnb93 sqrVX7587k7wqxaxb9kW+gtctHXT2SdViQe9Z15+ZqbDgtXha9n+L/h9KujzMsXMndXaEzT3 FgdnSF4yUrrItbXl54bNNw5tv75j+/U6+RNlttPmasusivkgmrQllO3RHSl/b6Fzty7NULBs 2HXn5e6WZb4926ZXKbEUZyQaajEXFScCABHEhCxdAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > arch/ia64/sn/pci/tioce_provider.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c > index 46d3df4..2f13276 100644 > --- a/arch/ia64/sn/pci/tioce_provider.c > +++ b/arch/ia64/sn/pci/tioce_provider.c > @@ -1000,11 +1000,11 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont > * Allocate kernel bus soft and copy from prom. > */ > > - tioce_common = kzalloc(sizeof(struct tioce_common), GFP_KERNEL); > + tioce_common = kmemdup(prom_bussoft, sizeof(struct tioce_common), > + GFP_KERNEL); > if (!tioce_common) > return NULL; > > - memcpy(tioce_common, prom_bussoft, sizeof(struct tioce_common)); > tioce_common->ce_pcibus.bs_base = (unsigned long) > ioremap(REGION_OFFSET(tioce_common->ce_pcibus.bs_base), > sizeof(struct tioce_common));