From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753671AbbIPJyj (ORCPT ); Wed, 16 Sep 2015 05:54:39 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:34804 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752216AbbIPJyh (ORCPT ); Wed, 16 Sep 2015 05:54:37 -0400 X-AuditID: cbfec7f5-f794b6d000001495-1f-55f93c5bc573 Subject: Re: [PATCH 08/31] arch/x86/intel-mid: use kmemdup rather than duplicating its implementation To: Thomas Gleixner References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-9-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org, x86@kernel.org From: Andrzej Hajda Message-id: <55F93C4F.2040200@samsung.com> Date: Wed, 16 Sep 2015 11:54:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1438934377-4922-9-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOLMWRmVeSWpSXmKPExsVy+t/xy7rRNj9DDe78k7LYOGM9q8XlXXPY LNYeuctusXnTVGaLHxseszqwemxa1cnm8e7cOXaPvi2rGD0+b5ILYInisklJzcksSy3St0vg ypjSf4Cl4BVHxec165gaGLewdzFyckgImEjsmXeWBcIWk7hwbz1bFyMXh5DAUkaJm3cnsEA4 zxkl5mz7zdjFyMEhLJAuceWzMUiDiICGxMZLt5hBbCGBaomjfUfBbGaB6YwS+7bngdhsApoS fzffZANp5RXQkni8tgjEZBFQlfj7yAqkQlQgQuLU2bdsIDavgKDEj8n3WEBKOAWcJb62BIGY zAJ6EvcvakHMlpfYvOYt8wRGgVlIGmYhVM1CUrWAkXkVo2hqaXJBcVJ6rpFecWJucWleul5y fu4mRkjwft3BuPSY1SFGAQ5GJR5eh5c/QoVYE8uKK3MPMUpwMCuJ8D6y+hkqxJuSWFmVWpQf X1Sak1p8iFGag0VJnHfmrvchQgLpiSWp2ampBalFMFkmDk6pBsYGxdKorUea6th1tPqbX7Kx b2XSyw9cERh/8IHtv+T+KrsllrPLNr01LJotmxGj8cReMixaPXH/WqEPl/xqrvwTlpBwENOs ummv+2RzS8ORtPxEs+dvEvffq7nSqBPOsGFdf3FR1R1vs8u3Tsz4/+rO8S1P3tvJCF+fx8R8 /6tVye4XgrrvTiixFGckGmoxFxUnAgBI5jHPWgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > arch/x86/platform/intel-mid/sfi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/platform/intel-mid/sfi.c b/arch/x86/platform/intel-mid/sfi.c > index ce992e8..5ee360a 100644 > --- a/arch/x86/platform/intel-mid/sfi.c > +++ b/arch/x86/platform/intel-mid/sfi.c > @@ -197,10 +197,9 @@ static int __init sfi_parse_gpio(struct sfi_table_header *table) > num = SFI_GET_NUM_ENTRIES(sb, struct sfi_gpio_table_entry); > pentry = (struct sfi_gpio_table_entry *)sb->pentry; > > - gpio_table = kmalloc(num * sizeof(*pentry), GFP_KERNEL); > + gpio_table = kmemdup(pentry, num * sizeof(*pentry), GFP_KERNEL); > if (!gpio_table) > return -1; > - memcpy(gpio_table, pentry, num * sizeof(*pentry)); > gpio_num_entry = num; > > pr_debug("GPIO pin info:\n");